You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/01/17 12:57:48 UTC

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20294

    [SPARK-23132][PYTHON][ML] Run doctests in ml.image when testing

    ## What changes were proposed in this pull request?
    
    This PR proposes to actually run the doctests in `ml/image.py`.
    
    ## How was this patch tested?
    
    doctests in `python/pyspark/ml/image.py`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark trigger-image

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20294
    
----
commit 9912444dc02026a5f20535ad225853884b9f4515
Author: hyukjinkwon <gu...@...>
Date:   2018-01-17T12:54:23Z

    Run doctests in ml.image when testing

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20294


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

Posted by imatiach-msft <gi...@git.apache.org>.
Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20294#discussion_r162082063
  
    --- Diff: python/pyspark/ml/image.py ---
    @@ -194,9 +194,9 @@ def readImages(self, path, recursive=False, numPartitions=-1,
             :return: a :class:`DataFrame` with a single column of "images",
                    see ImageSchema for details.
     
    -        >>> df = ImageSchema.readImages('python/test_support/image/kittens', recursive=True)
    +        >>> df = ImageSchema.readImages('data/mllib/images/kittens', recursive=True)
             >>> df.count()
    -        4
    +        5
    --- End diff --
    
    nice catch!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86268/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    Merged to master and branch-2.3.
    
    Thanks for reviewing this, @srowen, @imatiach-msft, @MrBago and @BryanCutler.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    **[Test build #86268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86268/testReport)** for PR 20294 at commit [`9912444`](https://github.com/apache/spark/commit/9912444dc02026a5f20535ad225853884b9f4515).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    cc @MrBago and @imatiach-msft, could you take a look when you are available please?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by imatiach-msft <gi...@git.apache.org>.
Github user imatiach-msft commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    nice fix!  Great to see the doctests run.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20294#discussion_r162043164
  
    --- Diff: python/pyspark/ml/image.py ---
    @@ -194,9 +194,9 @@ def readImages(self, path, recursive=False, numPartitions=-1,
             :return: a :class:`DataFrame` with a single column of "images",
                    see ImageSchema for details.
     
    -        >>> df = ImageSchema.readImages('python/test_support/image/kittens', recursive=True)
    +        >>> df = ImageSchema.readImages('data/mllib/images/kittens', recursive=True)
             >>> df.count()
    -        4
    +        5
    --- End diff --
    
    It becomes 5 since we don't `dropImageFailures`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20294
  
    **[Test build #86268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86268/testReport)** for PR 20294 at commit [`9912444`](https://github.com/apache/spark/commit/9912444dc02026a5f20535ad225853884b9f4515).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org