You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Ajay Garg (JIRA)" <ji...@apache.org> on 2008/06/05 09:03:45 UTC
[jira] Created: (PIG-256) support non default constructor with
variable number of arguments
support non default constructor with variable number of arguments
-----------------------------------------------------------------
Key: PIG-256
URL: https://issues.apache.org/jira/browse/PIG-256
Project: Pig
Issue Type: Improvement
Reporter: Ajay Garg
Priority: Minor
pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pi Song updated PIG-256:
------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pi Song updated PIG-256:
------------------------
Comment: was deleted
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602644#action_12602644 ]
Pi Song commented on PIG-256:
-----------------------------
This seems to follow the dispatching mechanism in Java so I agree.
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pi Song updated PIG-256:
------------------------
Status: Patch Available (was: Open)
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603180#action_12603180 ]
Olga Natkovich commented on PIG-256:
------------------------------------
sounds reasonable. please, attach the patch if you already have one
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pi Song updated PIG-256:
------------------------
Attachment: PIG_256_vararg_instantiation.patch
Simple fix.
All tests passed Local/MapReduce.
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604317#action_12604317 ]
Olga Natkovich commented on PIG-256:
------------------------------------
+1. The patch looks good! Please, commit
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604490#action_12604490 ]
Pi Song commented on PIG-256:
-----------------------------
Somebody please. I don't want to commit my own code.
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-256) support non default constructor with
variable number of arguments
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604497#action_12604497 ]
Pi Song commented on PIG-256:
-----------------------------
Committed. Thanks Olga for review.
> support non default constructor with variable number of arguments
> -----------------------------------------------------------------
>
> Key: PIG-256
> URL: https://issues.apache.org/jira/browse/PIG-256
> Project: Pig
> Issue Type: Improvement
> Reporter: Ajay Garg
> Priority: Minor
> Attachments: PIG_256_vararg_instantiation.patch
>
>
> pig does not support non default constructor with variable number of arguments support. In our case we need this because the number of variables that are specified by the user are varying. The fix is simple. Pig calls getConstr("agr1","arg2",...,"argn") and if it doesn't find it throws a noSuchMethodFound exception. In the catch block we just need to add code to check if we can wrap the arg1..n in a String[] and check if a constructor can be found with this signature getConstr(args[]). This would resolve the variable num args issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.