You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/22 18:40:17 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5126: [WIP][Relay] XXXNode::make to constructor

ANSHUMAN87 commented on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602253109
 
 
   I have only made changes for IfNode, to get your valuable opinion. Once it is through, i can follow same template for others.
   
   I had a dilemma of the format of constructor: 
       1:> If(IfNode(Args))
       2:> If(Args) --> Ifnode(Args)
   
   Currently implemented as per 1. 
   Eagerly waiting for your valuable feedback. TIA!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services