You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/02/18 20:23:06 UTC
Review Request 43731: Add Stack Advisor validations for
hawq_global_rm_type property in HAWQ
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43731/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-15083
https://issues.apache.org/jira/browse/AMBARI-15083
Repository: ambari
Description
-------
Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The below 2 cases must be covered:
# 1: If YARN service is not installed, and hawq_global_rm_type is set as yarn, a validation error should be thrown
# 2: If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no validation error should be thrown
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 545a2b5
Diff: https://reviews.apache.org/r/43731/diff/
Testing
-------
yes, manual and stack advisor test run.
Thanks,
bhuvnesh chaudhary
Re: Review Request 43731: Add Stack Advisor validations for
hawq_global_rm_type property in HAWQ
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43731/#review119699
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Feb. 18, 2016, 11:23 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43731/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 11:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-15083
> https://issues.apache.org/jira/browse/AMBARI-15083
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The below 2 cases must be covered:
> # 1: If YARN service is not installed, and hawq_global_rm_type is set as yarn, a validation error should be thrown
> # 2: If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no validation error should be thrown
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 545a2b5
>
> Diff: https://reviews.apache.org/r/43731/diff/
>
>
> Testing
> -------
>
> yes, manual and stack advisor test run.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 43731: Add Stack Advisor validations for
hawq_global_rm_type property in HAWQ
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43731/#review119771
-----------------------------------------------------------
Ship it!
Ship It!
- jun aoki
On Feb. 18, 2016, 7:23 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43731/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 7:23 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-15083
> https://issues.apache.org/jira/browse/AMBARI-15083
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The below 2 cases must be covered:
> # 1: If YARN service is not installed, and hawq_global_rm_type is set as yarn, a validation error should be thrown
> # 2: If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no validation error should be thrown
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 545a2b5
>
> Diff: https://reviews.apache.org/r/43731/diff/
>
>
> Testing
> -------
>
> yes, manual and stack advisor test run.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>