You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/16 22:33:13 UTC
[GitHub] [incubator-superset] junlincc opened a new issue #11721: [dashboard]filter mapping modal cosmetic issues
junlincc opened a new issue #11721:
URL: https://github.com/apache/incubator-superset/issues/11721
<img width="693" alt="Screen Shot 2020-11-16 at 2 24 28 PM" src="https://user-images.githubusercontent.com/67837651/99315874-38ab2b00-2818-11eb-84af-600a05156cfe.png">
1. checkbox and label alignment
2. line overflow
3. "Collapse all" and Search bar overlap
4. section divider
5. button position - move both to the bottom right, change "CLOSE" to "Cancel"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11721: [dashboard]filter mapping modal cosmetic issues
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11721:
URL: https://github.com/apache/incubator-superset/issues/11721#issuecomment-729824261
Regarding the width, that's how it was before - 80% of screen width. Do you think we should make it a bit narrower?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11721: [dashboard]filter mapping modal cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11721:
URL: https://github.com/apache/incubator-superset/issues/11721#issuecomment-729796536
<img width="1788" alt="Screen Shot 2020-11-18 at 8 04 42 AM" src="https://user-images.githubusercontent.com/67837651/99558275-69a27180-2978-11eb-86a0-895c6b470650.png">
tested, a bit too wide but is looking neat! thanks for the fix @kgabryje !!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11721: [dashboard]filter mapping modal cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11721:
URL: https://github.com/apache/incubator-superset/issues/11721#issuecomment-729830391
i think we are good for now, we are rolling out a new native configuration modal soon:) also wide modal can be good for long titles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #11721: [dashboard]filter mapping modal cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11721:
URL: https://github.com/apache/incubator-superset/issues/11721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org