You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2020/06/02 18:06:00 UTC

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

    [ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124161#comment-17124161 ] 

Michael Stack commented on HBASE-24492:
---------------------------------------

Can you give more history here please [~vjasani] so we can follow along. Why do we not need the while any more? Thanks.

> ProtobufLogReader.readNext does not need looping
> ------------------------------------------------
>
>                 Key: HBASE-24492
>                 URL: https://issues.apache.org/jira/browse/HBASE-24492
>             Project: HBase
>          Issue Type: Task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Minor
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method, however it returns value of throws errors in single execution. while(true) was part of initial code and with better improvements in the method, this loop has not been removed yet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)