You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/23 08:22:09 UTC
[GitHub] [airflow] vqcuong opened a new issue, #26622: Airflow webserver: make success button show a confirming pop-up that was not enable scroll down when have long list of tasks
vqcuong opened a new issue, #26622:
URL: https://github.com/apache/airflow/issues/26622
### Apache Airflow version
2.4.0
### What happened
I have a dag with more task in it. When click on "make success" button for a dag run on DAG ui, the pop-up showing tasks not enable scroll so I can see the "confirm" or "cancel" buttons at the end of it. The below images will describe this issue clearer
<img width="1440" alt="Screen Shot 2022-09-23 at 15 17 24" src="https://user-images.githubusercontent.com/35632030/191919336-02f8ea13-d2b7-497e-8a25-4e56a1ca8685.png">
<img width="1440" alt="Screen Shot 2022-09-23 at 15 15 25" src="https://user-images.githubusercontent.com/35632030/191919321-282fca5d-3632-4a7f-82a7-93e608a0708a.png">
### What you think should happen instead
I think this pop-up should enable scroll to prevent this issue
### How to reproduce
_No response_
### Operating System
Debian GNU/Linux 10 (buster)
### Versions of Apache Airflow Providers
_No response_
### Deployment
Docker-Compose
### Deployment details
I using an official docker-compose on airflow github to deploy
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #26622: Airflow webserver: make success button should show a scrollable pop-up of tasks
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #26622:
URL: https://github.com/apache/airflow/issues/26622#issuecomment-1257211596
@vqcuong how did you solve this ? Wondering if we should still make this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vqcuong closed issue #26622: Airflow webserver: make success button should show a scrollable pop-up of tasks
Posted by GitBox <gi...@apache.org>.
vqcuong closed issue #26622: Airflow webserver: make success button should show a scrollable pop-up of tasks
URL: https://github.com/apache/airflow/issues/26622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #26622: Airflow webserver: make success button should show a scrollable pop-up of tasks
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #26622:
URL: https://github.com/apache/airflow/issues/26622#issuecomment-1257021981
Thank you for reporting this issue.
Indeed it looks like the overflow is not properly handled for the dialog component. (On chrome I can scroll the modal content by playing around but it definitely feels buggy).
Maybe we could have a maxHeight ~90% of the vertical space, and add a scrollbar to the task instances list :thinking: ? (cf screenshot)
Would be glad to review a PR for this. @vqcuong, do you want to take this one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vqcuong commented on issue #26622: Airflow webserver: make success button should show a scrollable pop-up of tasks
Posted by GitBox <gi...@apache.org>.
vqcuong commented on issue #26622:
URL: https://github.com/apache/airflow/issues/26622#issuecomment-1257193838
Hi @pierrejeambrun, sorry for my bad. I have found an issue from my deployment solution. Thank for help me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org