You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marcus Sorensen <sh...@gmail.com> on 2013/04/23 00:52:50 UTC

Review Request: fix RPM version on non-SNAPSHOT releases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10714/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

When trying to make RPMs from the current 4.1, I ran into this because the "-SNAPSHOT" has been removed:

[marcus@buildcloud centos63]$ ./package.sh 
error: Macro %_ver has empty body
error: Macro %_ver has empty body
error: File /home/marcus/code/cloudstack/dist/rpmbuild/SOURCES/cloudstack-%{_ver}.tgz: No such file or directory


Diffs
-----

  packaging/centos63/package.sh d9d5b1c 

Diff: https://reviews.apache.org/r/10714/diff/


Testing
-------

Built RPMs successfully


Thanks,

Marcus Sorensen


Re: Review Request: fix RPM version on non-SNAPSHOT releases

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10714/#review19563
-----------------------------------------------------------

Ship it!


Ship It!

- Chip Childers


On April 22, 2013, 10:52 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10714/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 10:52 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> When trying to make RPMs from the current 4.1, I ran into this because the "-SNAPSHOT" has been removed:
> 
> [marcus@buildcloud centos63]$ ./package.sh 
> error: Macro %_ver has empty body
> error: Macro %_ver has empty body
> error: File /home/marcus/code/cloudstack/dist/rpmbuild/SOURCES/cloudstack-%{_ver}.tgz: No such file or directory
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/package.sh d9d5b1c 
> 
> Diff: https://reviews.apache.org/r/10714/diff/
> 
> 
> Testing
> -------
> 
> Built RPMs successfully
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>