You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Evgeny Bogdanov <ev...@epfl.ch> on 2012/02/02 11:53:21 UTC
Re: Review Request: A patch that enables API for updating person data
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/
-----------------------------------------------------------
(Updated 2012-02-02 10:53:21.630237)
Review request for shindig.
Changes
-------
New patch is applied.
As discussed, by default only the viewer can update his own info.
The containers can override this behavior in PersonServiceDb.java
For example,
String uid = id.getUserId(token);
instead of
String uid = token.getViewerId();
Test for osapi.people.update is added as well
Summary
-------
A patch that enables API for updating person data
PUT people/12/@self
osapi.people.update()
for this JIRA reports
https://issues.apache.org/jira/browse/SHINDIG-1674
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1239531
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1239531
Diff: https://reviews.apache.org/r/3544/diff
Testing
-------
tests are in the patch
Thanks,
Evgeny
Re: Review Request: A patch that enables API for updating person data
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4769
-----------------------------------------------------------
See inline comments.
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java
<https://reviews.apache.org/r/3544/#comment10491>
Is the intent here to punish someone who is trying to update someone else's data? :)
Scenario:
Viewer = john.doe
POST to rpc endpoint
[
{
"method":"people.update",
"id":"people.update",
"params":{
"person":{
"displayName":"Foo Bar"
},
"userId":"jane.doe"
}
}
]
POST to rpc endpoint
[
{
"method":"people.get",
"id":"people.get",
"params":{
"fields":[
"name",
"displayName"
],
"userId":"@viewer",
"groupId":"@self"
}
}
]
Result: John Doe's display name is now "Foo Bar"!
My suggestion is that you create a protected method in PersonServiceDb to check if a person is allowed to update the given person record. By default this method would return true iff the viewer and person id are the same. If the method returned false, we would want to return a 403 or the like. Someone could then override this to provide the admin functionality we've discussed previously.
- Stanton
On 2012-02-02 10:53:21, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 10:53:21)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1239531
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1239531
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4864
-----------------------------------------------------------
Ship it!
lgtm -- modulo trailing whitespace.
- Paul
On 2012-02-07 10:42:50, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 10:42:50)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4862
-----------------------------------------------------------
Ship it!
Fix the whitespace and you are good to go!
- Ryan
On 2012-02-07 10:42:50, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 10:42:50)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4898
-----------------------------------------------------------
Regarding whitespace, you should not have any trailing whitespace or whitespace on empty lines. This will show up in red in the diffs on Review Board.
You can look here (https://cwiki.apache.org/SHINDIGxSITE/java-style.html) and (https://cwiki.apache.org/confluence/display/SHINDIGxSITE/Javascript+Style) for style guidelines. If you use Eclipse, you can find resources that can be imported to configure the Eclipse formatters in Shindig trunk /etc/eclipse.
I know Dan removes whitespace this way:
"FYI:
In eclipse, Ctrl+F
Find: [ \t]+$
Replace with:
Check off "Regular expressions" and then press "Replace All" :)"
- Stanton
On 2012-02-08 10:27:44, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 10:27:44)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person
data
Posted by Evgeny Bogdanov <ev...@epfl.ch>.
All done now.
Best
Evgeny
On 08.02.12 22:52, Stanton Sievers wrote:
> Beat me to it! I just remembered I forgot that step.
>
> Evgeny, can you also close the review if you haven't done so already.
>
>
> Thanks,
> -Stanton
>
>
>
> From: Henry Saputra<he...@gmail.com>
> To: dev@shindig.apache.org,
> Date: 02/08/2012 16:49
> Subject: Re: Review Request: A patch that enables API for updating
> person data
>
>
>
> Evgeny,
>
> Could you upload the final patch to JIRA for legal purpose?
>
> - Henry
>
> On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers<si...@gmail.com>
> wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/3544/#review4900
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Committed r1241890
>>
>> Thanks!
>>
>> - Stanton
>>
>>
>> On 2012-02-08 12:49:18, Evgeny Bogdanov wrote:
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/3544/
>>> -----------------------------------------------------------
>>>
>>> (Updated 2012-02-08 12:49:18)
>>>
>>>
>>> Review request for shindig.
>>>
>>>
>>> Summary
>>> -------
>>>
>>> A patch that enables API for updating person data
>>> PUT people/12/@self
>>> osapi.people.update()
>>>
>>>
>>> for this JIRA reports
>>> https://issues.apache.org/jira/browse/SHINDIG-1674
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java
> 1241411
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java
> 1241411
>>> Diff: https://reviews.apache.org/r/3544/diff
>>>
>>>
>>> Testing
>>> -------
>>>
>>> tests are in the patch
>>>
>>>
>>> Thanks,
>>>
>>> Evgeny
>>>
>>>
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Stanton Sievers <ss...@us.ibm.com>.
Beat me to it! I just remembered I forgot that step.
Evgeny, can you also close the review if you haven't done so already.
Thanks,
-Stanton
From: Henry Saputra <he...@gmail.com>
To: dev@shindig.apache.org,
Date: 02/08/2012 16:49
Subject: Re: Review Request: A patch that enables API for updating
person data
Evgeny,
Could you upload the final patch to JIRA for legal purpose?
- Henry
On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers <si...@gmail.com>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/#review4900
> -----------------------------------------------------------
>
> Ship it!
>
>
> Committed r1241890
>
> Thanks!
>
> - Stanton
>
>
> On 2012-02-08 12:49:18, Evgeny Bogdanov wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/3544/
>> -----------------------------------------------------------
>>
>> (Updated 2012-02-08 12:49:18)
>>
>>
>> Review request for shindig.
>>
>>
>> Summary
>> -------
>>
>> A patch that enables API for updating person data
>> PUT people/12/@self
>> osapi.people.update()
>>
>>
>> for this JIRA reports
>> https://issues.apache.org/jira/browse/SHINDIG-1674
>>
>>
>> Diffs
>> -----
>>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java
1241411
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java
1241411
>>
>> Diff: https://reviews.apache.org/r/3544/diff
>>
>>
>> Testing
>> -------
>>
>> tests are in the patch
>>
>>
>> Thanks,
>>
>> Evgeny
>>
>>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Henry Saputra <he...@gmail.com>.
Evgeny,
Could you upload the final patch to JIRA for legal purpose?
- Henry
On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers <si...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/#review4900
> -----------------------------------------------------------
>
> Ship it!
>
>
> Committed r1241890
>
> Thanks!
>
> - Stanton
>
>
> On 2012-02-08 12:49:18, Evgeny Bogdanov wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/3544/
>> -----------------------------------------------------------
>>
>> (Updated 2012-02-08 12:49:18)
>>
>>
>> Review request for shindig.
>>
>>
>> Summary
>> -------
>>
>> A patch that enables API for updating person data
>> PUT people/12/@self
>> osapi.people.update()
>>
>>
>> for this JIRA reports
>> https://issues.apache.org/jira/browse/SHINDIG-1674
>>
>>
>> Diffs
>> -----
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
>> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
>>
>> Diff: https://reviews.apache.org/r/3544/diff
>>
>>
>> Testing
>> -------
>>
>> tests are in the patch
>>
>>
>> Thanks,
>>
>> Evgeny
>>
>>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4900
-----------------------------------------------------------
Ship it!
Committed r1241890
Thanks!
- Stanton
On 2012-02-08 12:49:18, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 12:49:18)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Evgeny Bogdanov <ev...@epfl.ch>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/
-----------------------------------------------------------
(Updated 2012-02-08 12:49:18.692350)
Review request for shindig.
Changes
-------
All trailing whitespaces are removed.
Please ship it whoever has committing access to shindig.
Summary
-------
A patch that enables API for updating person data
PUT people/12/@self
osapi.people.update()
for this JIRA reports
https://issues.apache.org/jira/browse/SHINDIG-1674
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
Diff: https://reviews.apache.org/r/3544/diff
Testing
-------
tests are in the patch
Thanks,
Evgeny
Re: Review Request: A patch that enables API for updating person data
Posted by Evgeny Bogdanov <ev...@epfl.ch>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/
-----------------------------------------------------------
(Updated 2012-02-08 10:27:44.989959)
Review request for shindig.
Changes
-------
Whitespaces in the end of the line with text are removed.
What about empty lines? Should there be a whitespace aligned with the beginning of the previous line with text?
I checked other shindig code, there are both variants present?
What's the rule?
How is doing shipping ? :)
Summary
-------
A patch that enables API for updating person data
PUT people/12/@self
osapi.people.update()
for this JIRA reports
https://issues.apache.org/jira/browse/SHINDIG-1674
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
Diff: https://reviews.apache.org/r/3544/diff
Testing
-------
tests are in the patch
Thanks,
Evgeny
Re: Review Request: A patch that enables API for updating person data
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4858
-----------------------------------------------------------
Ship it!
Looks like some whitespace is still popping up, but other than that this looks good to me. Thanks!
- Stanton
On 2012-02-07 10:42:50, Evgeny Bogdanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 10:42:50)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
>
>
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
>
> Diff: https://reviews.apache.org/r/3544/diff
>
>
> Testing
> -------
>
> tests are in the patch
>
>
> Thanks,
>
> Evgeny
>
>
Re: Review Request: A patch that enables API for updating person data
Posted by Evgeny Bogdanov <ev...@epfl.ch>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/
-----------------------------------------------------------
(Updated 2012-02-07 10:42:50.013242)
Review request for shindig.
Changes
-------
2Stanton: Bad behavior should be punished! :)
Attached the patch that has implementation of your suggestion + 3 tests for it (client side, personservicedb and jsonservicedb).
Summary
-------
A patch that enables API for updating person data
PUT people/12/@self
osapi.people.update()
for this JIRA reports
https://issues.apache.org/jira/browse/SHINDIG-1674
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411
Diff: https://reviews.apache.org/r/3544/diff
Testing
-------
tests are in the patch
Thanks,
Evgeny