You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/11 12:45:41 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #4637: support
`java` -> `nginx` -> `java` e2e test, and v3 protocol
mrproliu opened a new pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
#4455
___
### New feature or improvement
- add `java` -> `nginx` -> `java` e2e test.
- adapt the new v3 protocol backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4637: support `java`
-> `nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#discussion_r407063626
##########
File path: test/e2e/e2e-test/docker/lua/docker-compose.yml
##########
@@ -42,7 +42,27 @@ services:
oap:
condition: service_healthy
- provider:
+ provider-entry:
+ build:
+ context: ../../../
+ dockerfile: e2e-test/docker/Dockerfile.provider
+ networks:
+ - e2e
+ expose:
+ - 9091
Review comment:
```suggestion
- 9090
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#discussion_r407063686
##########
File path: test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/LuaE2E.java
##########
@@ -77,17 +77,22 @@
@ContainerHostAndPort(name = "ui", port = 8080)
private HostAndPort swWebappHostPort;
+ @SuppressWarnings("unused")
+ @ContainerHostAndPort(name = "provider-entry", port = 8080)
Review comment:
```suggestion
@ContainerHostAndPort(name = "provider-entry", port = 9090)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on a change in pull request #4637:
support `java` -> `nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#discussion_r407063836
##########
File path: test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/LuaE2E.java
##########
@@ -77,17 +77,22 @@
@ContainerHostAndPort(name = "ui", port = 8080)
private HostAndPort swWebappHostPort;
+ @SuppressWarnings("unused")
+ @ContainerHostAndPort(name = "provider-entry", port = 8080)
Review comment:
Thanks for your help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on issue #4637: support `java` ->
`nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#issuecomment-612415299
> I think related to #4617 too?
yes, I lost that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#discussion_r407063653
##########
File path: test/e2e/e2e-test/docker/lua/docker-compose.yml
##########
@@ -42,7 +42,27 @@ services:
oap:
condition: service_healthy
- provider:
+ provider-entry:
+ build:
+ context: ../../../
+ dockerfile: e2e-test/docker/Dockerfile.provider
+ networks:
+ - e2e
+ expose:
+ - 9091
+ environment:
+ - SW_AGENT_COLLECTOR_BACKEND_SERVICES=oap:11800
+ - SW_AGENT_NAME=e2e-service-entry-provider
+ depends_on:
+ oap:
+ condition: service_healthy
+ healthcheck:
+ test: ["CMD", "sh", "-c", "nc -z 127.0.0.1 9091"]
Review comment:
```suggestion
test: ["CMD", "sh", "-c", "nc -z 127.0.0.1 9090"]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4637: support `java` ->
`nginx` -> `java` e2e test, and v3 protocol
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4637: support `java` -> `nginx` -> `java` e2e test, and v3 protocol
URL: https://github.com/apache/skywalking/pull/4637#issuecomment-612414875
I think related to #4617 too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services