[jira] [Commented] (GEODE-8259) DSFIDSerializerImpl should handle RTE the same as Exception

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136296#comment-17136296 ] 

ASF GitHub Bot commented on GEODE-8259:
---------------------------------------

gesterzhou opened a new pull request #5253:
URL: https://github.com/apache/geode/pull/5253


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DSFIDSerializerImpl should handle RTE the same as Exception
> -----------------------------------------------------------
>
>                 Key: GEODE-8259
>                 URL: https://issues.apache.org/jira/browse/GEODE-8259
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Xiaojian Zhou
>            Priority: Major
>
> In GEOEDE-7090, DSFIDSerializerImpl.invokeFromData() will catch RunTimeException and throw. But convert Exception to be IOException. The idea is to avoid using SerializationException which is in another package. 
> However, if my fromData() failed with IndexOutOfBoundary exception (which is an RTE), it will be thrown directly instead of treating it in handleException(), thus my serialization exception will never get handled. 
> The fix is to merge the catch RunTimeException into catch Exception.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)