You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nabarunnag <gi...@git.apache.org> on 2017/04/26 17:14:07 UTC
[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/479
GEM-1331: AEQ created before the user region
Potential reviewers
@gesterzhou @upthewaterspout @jhuynh1 @ladyVader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2828
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 01e70078cec53536807b0e85dd30fca7ad790de2
Author: nabarun <nn...@pivotal.io>
Date: 2017-04-26T01:20:37Z
GEODE-2828: AEQ being created before the user region
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #479: GEM-1331: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/479
Pushed to develop
Failure in Travis fixed in GEODE-2632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
GitHub user nabarunnag reopened a pull request:
https://github.com/apache/geode/pull/479
GEM-1331: AEQ created before the user region
Potential reviewers
@gesterzhou @upthewaterspout @jhuynh1 @ladyVader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2828
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 01e70078cec53536807b0e85dd30fca7ad790de2
Author: nabarun <nn...@pivotal.io>
Date: 2017-04-26T01:20:37Z
GEODE-2828: AEQ being created before the user region
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Posted by jhuynh1 <gi...@git.apache.org>.
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113565230
--- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java ---
@@ -166,28 +166,28 @@ public void createIndex(final String indexName, String regionPath, final Analyze
*
* Public because this is called by the Xml parsing code
*/
- public void afterDataRegionCreated(final String indexName, final Analyzer analyzer,
- final String dataRegionPath, final Map<String, Analyzer> fieldAnalyzers,
- final String... fields) {
- LuceneIndexImpl index = createIndexRegions(indexName, dataRegionPath);
- index.setSearchableFields(fields);
- index.setAnalyzer(analyzer);
- index.setFieldAnalyzers(fieldAnalyzers);
+ public void afterDataRegionCreated(LuceneIndexImpl index) {
index.initialize();
registerIndex(index);
if (this.managementListener != null) {
this.managementListener.afterIndexCreated(index);
}
+
+ }
+
+ public LuceneIndexImpl beforeDataRegionCreated(final String indexName, final String regionPath,
+ RegionAttributes attributes, final Analyzer analyzer,
+ final Map<String, Analyzer> fieldAnalyzers, String aeqId, final String... fields) {
+ LuceneIndexImpl index = createIndexRegions(indexName, regionPath);
--- End diff --
This wasn't introduced with this diff, but we probably want to rename this method. I don't think the method is creating any index regions. I think it's just creating the index object but none of the file/chunk or aeq region or buckets
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113564312
--- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java ---
@@ -53,6 +54,8 @@
Logger logger = LogService.getLogger();
private final RepositoryManager repositoryManager;
+ private CountDownLatch isFileAndChunkRegionReady = new CountDownLatch(1);
+ private boolean ready = false;
--- End diff --
Does this need to be a separate flag? Seems like the CoutDownLatch already has the flag. If not this should be volatile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113630711
--- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java ---
@@ -166,28 +166,28 @@ public void createIndex(final String indexName, String regionPath, final Analyze
*
* Public because this is called by the Xml parsing code
*/
- public void afterDataRegionCreated(final String indexName, final Analyzer analyzer,
- final String dataRegionPath, final Map<String, Analyzer> fieldAnalyzers,
- final String... fields) {
- LuceneIndexImpl index = createIndexRegions(indexName, dataRegionPath);
- index.setSearchableFields(fields);
- index.setAnalyzer(analyzer);
- index.setFieldAnalyzers(fieldAnalyzers);
+ public void afterDataRegionCreated(LuceneIndexImpl index) {
index.initialize();
registerIndex(index);
if (this.managementListener != null) {
this.managementListener.afterIndexCreated(index);
}
+
+ }
+
+ public LuceneIndexImpl beforeDataRegionCreated(final String indexName, final String regionPath,
+ RegionAttributes attributes, final Analyzer analyzer,
+ final Map<String, Analyzer> fieldAnalyzers, String aeqId, final String... fields) {
+ LuceneIndexImpl index = createIndexRegions(indexName, regionPath);
--- End diff --
Changed it to createIndexObject - any better suggestion is welcomed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #479: GEODE-2828: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/479
Sending in a fresh pull request with all modification
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag closed the pull request at:
https://github.com/apache/geode/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113630780
--- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java ---
@@ -53,6 +54,8 @@
Logger logger = LogService.getLogger();
private final RepositoryManager repositoryManager;
+ private CountDownLatch isFileAndChunkRegionReady = new CountDownLatch(1);
+ private boolean ready = false;
--- End diff --
Removed the flag and lucene precheckin was success.
Futher testing is ongoing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag closed the pull request at:
https://github.com/apache/geode/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---