You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/27 05:55:15 UTC

[GitHub] jai1 commented on a change in pull request #1451: Fix: NPE on http-lookup redirection

jai1 commented on a change in pull request #1451: Fix: NPE on http-lookup redirection
URL: https://github.com/apache/incubator-pulsar/pull/1451#discussion_r177314778
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
 ##########
 @@ -264,7 +265,8 @@ protected void validateClusterOwnership(String cluster) throws WebApplicationExc
 
     private URI getRedirectionUrl(ClusterData differentClusterData) throws MalformedURLException {
         URL webUrl = null;
-        if (pulsar.getConfiguration().isTlsEnabled() && !differentClusterData.getServiceUrlTls().isEmpty()) {
+        if (isRequestHttps() && pulsar.getConfiguration().isTlsEnabled()
 
 Review comment:
   isTlsEnabled check is not required

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services