You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/03 20:41:32 UTC
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4937
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
[OpenSSL] require at least 1.0.1 version
To build the project, it's necessary to have OpenSSL version 1.0.1
or higher.
Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4937/1
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4937
to look at the new patch set (#2).
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
[OpenSSL] require at least 1.0.1 version
To build the project, it's necessary to have OpenSSL version 1.0.1
or higher: we are using TLS v 1.2.
Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
---
M CMakeLists.txt
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4937/2
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 2:
Yea, I think we need to build against RHEL6.4's OpenSSL. (I have the local hack necessary to use the old-style functions when the new ones aren't available, will work on getting that into a patch in the next day or two)
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 2:
> In Sailesh's patch, there are few functions which have appeared
> starting OpenSSL 1.0.1.
>
> Do we still want to make it working on against system OpenSSL on
> RHel/CentOS 6.4? It seemed to me there was an idea to compile the
> library as a third-party for RHel/CentOS 6.4. OK, we can clarify
> on that.
Yes, please follow-up with Todd before merging this.
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.0 version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [OpenSSL] require at least 1.0.0 version
......................................................................
[OpenSSL] require at least 1.0.0 version
To build the project, it's necessary to have OpenSSL version 1.0.0
or higher: we are using some features which have been introduced
in version 1.0.0 of the OpenSSL framework.
Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Reviewed-on: http://gerrit.cloudera.org:8080/4937
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M CMakeLists.txt
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4937/1/CMakeLists.txt
File CMakeLists.txt:
Line 833: find_package(OpenSSL 1.0.1 REQUIRED)
> Nit: not your fault but would you mind adding a little "## OpenSSL" header
Sure, np. Actually, I have that in my other patch :)
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [OpenSSL] require at least 1.0.0 version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.0 version
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 1:
(1 comment)
But el6.4 ships with 1.0.0, which I think we intend to build against (since it's the last release without symbol versions). What do we need from 1.0.1?
http://gerrit.cloudera.org:8080/#/c/4937/1/CMakeLists.txt
File CMakeLists.txt:
Line 833: find_package(OpenSSL 1.0.1 REQUIRED)
Nit: not your fault but would you mind adding a little "## OpenSSL" header just above this line?
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 2:
> Yea, I think we need to build against RHEL6.4's OpenSSL. (I have
> the local hack necessary to use the old-style functions when the
> new ones aren't available, will work on getting that into a patch
> in the next day or two)
That would be great to have such a patch! I'll wait for that then, holding off this one for a while.
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................
Patch Set 1:
> (1 comment)
>
> But el6.4 ships with 1.0.0, which I think we intend to build
> against (since it's the last release without symbol versions). What
> do we need from 1.0.1?
In Sailesh's patch, there are few functions which have appeared starting OpenSSL 1.0.1.
Do we still want to make it working on against system OpenSSL on RHel/CentOS 6.4? It seemed to me there was an idea to compile the library as a third-party for RHel/CentOS 6.4. OK, we can clarify on that.
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [OpenSSL] require at least 1.0.0 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4937
to look at the new patch set (#3).
Change subject: [OpenSSL] require at least 1.0.0 version
......................................................................
[OpenSSL] require at least 1.0.0 version
To build the project, it's necessary to have OpenSSL version 1.0.0
or higher: we are using some features which have been introduced
in version 1.0.0 of the OpenSSL framework.
Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
---
M CMakeLists.txt
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4937/3
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>