You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Simon Gaeremynck (JIRA)" <ji...@apache.org> on 2010/07/08 19:43:50 UTC
[jira] Created: (SLING-1590) OSGi events should contain a userID
when possible.
OSGi events should contain a userID when possible.
--------------------------------------------------
Key: SLING-1590
URL: https://issues.apache.org/jira/browse/SLING-1590
Project: Sling
Issue Type: Improvement
Components: JCR
Affects Versions: API 2.0.8, JCR Resource 2.0.8
Reporter: Simon Gaeremynck
Attachments: userids-in-events.diff
We're building a system that tracks the user's movements in the system.
One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
I'll attach a patch that includes this functionality.
AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886503#action_12886503 ]
Justin Edelson commented on SLING-1590:
---------------------------------------
I'm getting some test failures locally, but that could be unrelated to the patch...
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886501#action_12886501 ]
Ian Boston commented on SLING-1590:
-----------------------------------
Although the patch is a bit confusing, just because of the way diff decided to lay things out, LGTM.
Can anyone see a reason why user ID should not be exposed in events ?
If not I will be happy to apply.
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886505#action_12886505 ]
Justin Edelson commented on SLING-1590:
---------------------------------------
nevermind. user error on my part.
patch looks fine to me.
Ian - I can commit this or you can (isn't it getting a bit late in the day for you? :)
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-1590:
----------------------------------
Assignee: Justin Edelson
Fix Version/s: JCR Resource 2.0.8
API 2.1.0
Component/s: API
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: API, JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Assignee: Justin Edelson
> Fix For: JCR Resource 2.0.8, API 2.1.0
>
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886514#action_12886514 ]
Ian Boston commented on SLING-1590:
-----------------------------------
Justin, Yes go for it,
coding with red wine in hand can be error prone.... especially if you spill it.
thanks
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Simon Gaeremynck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Gaeremynck updated SLING-1590:
------------------------------------
Attachment: userids-in-events.diff
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1590) OSGi events should contain a userID
when possible.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-1590.
-----------------------------------
Resolution: Fixed
applied patch in r961957
> OSGi events should contain a userID when possible.
> --------------------------------------------------
>
> Key: SLING-1590
> URL: https://issues.apache.org/jira/browse/SLING-1590
> Project: Sling
> Issue Type: Improvement
> Components: API, JCR
> Affects Versions: JCR Resource 2.0.8, API 2.0.8
> Reporter: Simon Gaeremynck
> Assignee: Justin Edelson
> Fix For: JCR Resource 2.0.8, API 2.1.0
>
> Attachments: userids-in-events.diff
>
>
> We're building a system that tracks the user's movements in the system.
> One of the things we're tracking is the OSGi events that are emitted by Sling. These don't contain a userid however.
> Since this all hapens in the JcrResourceListener which is a JCR Observation Listener, getting the userID is fairly straightforward.
> I'll attach a patch that includes this functionality.
> AFAICT this is the only location that emits user generated events, if I missed a spot I'd be happy to try and patch that one as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.