You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by tr...@apache.org on 2009/06/07 21:14:59 UTC

svn commit: r782437 - /apr/apr/branches/1.4.x/build/apr_hints.m4

Author: trawick
Date: Sun Jun  7 19:14:59 2009
New Revision: 782437

URL: http://svn.apache.org/viewvc?rev=782437&view=rev
Log:
Merge r782430 from trunk:

forward-port part of r781073 from the 1.3.x branch

as in 1.3.x, kqueue() is disabled
poll() use is unchanged
  in my testing, poll() use is okay in 1.4.x and trunk because the wakeup pipe support
  added in 1.4.x has a side-effect of working around OS X poll() bogosity


Modified:
    apr/apr/branches/1.4.x/build/apr_hints.m4

Modified: apr/apr/branches/1.4.x/build/apr_hints.m4
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.4.x/build/apr_hints.m4?rev=782437&r1=782436&r2=782437&view=diff
==============================================================================
--- apr/apr/branches/1.4.x/build/apr_hints.m4 (original)
+++ apr/apr/branches/1.4.x/build/apr_hints.m4 Sun Jun  7 19:14:59 2009
@@ -194,14 +194,15 @@
     *-apple-darwin*)
         APR_ADDTO(CPPFLAGS, [-DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp])
         APR_SETIFNULL(apr_posixsem_is_global, [yes])
-        # kqueue works in 10.5/Darwin 9.x. Disable on all older versions.
         case $host in
+            *-apple-darwin*)
+	        # APR's use of kqueue has triggered kernel panics for some
+                # 10.5.x (Darwin 9.x) users when running the entire test suite.
+                # In 10.4.x, use of kqueue would cause the socket tests to hang.
+                APR_SETIFNULL(ac_cv_func_kqueue, [no]) 
+                ;;
             *-apple-darwin[[0-8]].*)
-            # kqueue is broken on OS X, the poll tests work, but the socket tests
-            # hang when it's turned on.  if you decide to reenable this please be
-            # sure to test that ALL the tests continue to work with it turned on.
-            APR_SETIFNULL(ac_cv_func_kqueue, [no]) 
-            APR_SETIFNULL(ac_cv_func_poll, [no]) # See issue 34332
+                APR_SETIFNULL(ac_cv_func_poll, [no]) # See issue 34332
             ;;
         esac
 	;;