You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/09/07 15:31:55 UTC
[lucene-solr] 01/02: @778 Make thread safe.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 3494c2701d55801ac099fa4acfae3583d553a890
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Mon Sep 7 09:42:16 2020 -0500
@778 Make thread safe.
---
.../java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java b/solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java
index a32f26e..f3facf7 100644
--- a/solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java
+++ b/solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java
@@ -41,6 +41,8 @@ import java.util.EnumMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicReference;
@@ -206,7 +208,7 @@ public class AddReplicaCmd implements OverseerCollectionMessageHandler.Cmd {
}
if (asyncId != null) {
- List<String> coreNodeNames = new ArrayList<>();
+ Set<String> coreNodeNames = ConcurrentHashMap.newKeySet(createReplicas.size());
for (CreateReplica replica : createReplicas) {
coreNodeNames.add(ocmh.waitForCoreNodeName(zkStateReader, collectionName, replica.node, replica.coreName));
}
@@ -247,7 +249,7 @@ public class AddReplicaCmd implements OverseerCollectionMessageHandler.Cmd {
if (asyncId == null) {
- List<String> coreNodeNames = new ArrayList<>();
+ Set<String> coreNodeNames = ConcurrentHashMap.newKeySet(createReplicas.size());
for (CreateReplica replica : createReplicas) {
coreNodeNames.add(ocmh.waitForCoreNodeName(zkStateReader, collectionName, replica.node, replica.coreName));
}