You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/04/27 03:05:16 UTC

[GitHub] storm pull request: STORM-1731 (0.10.x) Avoid looking up debug / b...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1364

    STORM-1731 (0.10.x) Avoid looking up debug / backpressure enable flags within critical path

    * preload the value of flags and use that value
      * topology.debug
    
    Pull request for 1.x version is here: #1362 
    I don't take performance tests on this pull request, since #1362 shows the benefit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-1731-0.10.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1364
    
----
commit 1cc5228e3195826836e353342407fea290ea9122
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-04-27T01:03:04Z

    STORM-1731 Avoid looking up debug / backpressure enable flags within critical path
    
    * preload the value of flags and use that value
      * topology.debug

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1731 (0.10.x) Avoid looking up debug / b...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1364


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1731 (0.10.x) Avoid looking up debug / b...

Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:

    https://github.com/apache/storm/pull/1364#issuecomment-215084480
  
    +1 Great Finding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1731 (0.10.x) Avoid looking up debug / b...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/1364#issuecomment-214956239
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---