You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/19 12:32:21 UTC

[jira] [Commented] (FLINK-4288) Make it possible to unregister tables

    [ https://issues.apache.org/jira/browse/FLINK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503274#comment-15503274 ] 

ASF GitHub Bot commented on FLINK-4288:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2511

    [FLINK-4288] [table] Make it possible to unregister tables

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR adds the possibility to unregister tables. Although Calcite supports mutable schemas, deleting a table instead of replacing it was not easy to implement. I will add some documentation if you are fine with this PR.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4288

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2511
    
----
commit 0ecb6138680498bdacb134eff1609b21cbb07cd9
Author: twalthr <tw...@apache.org>
Date:   2016-09-19T12:09:14Z

    [FLINK-4288] [table] Make it possible to unregister tables

----


> Make it possible to unregister tables
> -------------------------------------
>
>                 Key: FLINK-4288
>                 URL: https://issues.apache.org/jira/browse/FLINK-4288
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Table names can not be changed yet. After registration you can not modify the table behind a table name. Maybe this behavior is too restrictive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)