[GitHub] [jclouds] jiffysrc commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

[GitBox <gi...@apache.org>]

jiffysrc commented on a change in pull request #125:
URL: https://github.com/apache/jclouds/pull/125#discussion_r775462468



##########
File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java
##########
@@ -184,7 +184,7 @@ protected void bindErrorHandlers() {
    }
 
    protected void bindRequestSigner() {
-      bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV2.class).in(Scopes.SINGLETON);
+      bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV4.class).in(Scopes.SINGLETON);

Review comment:
       Hi @gaul 
   We will be raising this change in separate PR as suggested.
   and could you please elaborate on how to document for older signer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org