You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/06 13:22:38 UTC
[GitHub] [incubator-inlong] thexiay opened a new pull request, #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
thexiay opened a new pull request, #4540:
URL: https://github.com/apache/incubator-inlong/pull/4540
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
- Fixes #4292
### Motivation
Unify all log output formats，simplifies user configuration
### Modifications
Upgrade all log4j properties to log4j2 properties. Syntax upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4540:
URL: https://github.com/apache/incubator-inlong/pull/4540#discussion_r890266219
##########
inlong-agent/agent-common/src/test/resources/log4j2.properties:
##########
@@ -14,7 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-log4j.rootLogger=INFO, out
-log4j.appender.out=org.apache.log4j.ConsoleAppender
-log4j.appender.out.layout=org.apache.log4j.PatternLayout
-log4j.appender.out.layout.ConversionPattern=%d (%t) [%p - %l] %m%n
\ No newline at end of file
+rootLogger=INFO, out
Review Comment:
This change seems like already merged, please rebase from the master branch first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] thexiay closed pull request #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
Posted by GitBox <gi...@apache.org>.
thexiay closed pull request #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
URL: https://github.com/apache/incubator-inlong/pull/4540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #4540:
URL: https://github.com/apache/incubator-inlong/pull/4540#issuecomment-1148130959
Duplicate with #4293.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] thexiay commented on a diff in pull request #4540: [INLONG-4292][Sort][Manager][Agent][TubeMQ] Upgrade log4j version configuration
Posted by GitBox <gi...@apache.org>.
thexiay commented on code in PR #4540:
URL: https://github.com/apache/incubator-inlong/pull/4540#discussion_r890713513
##########
inlong-agent/agent-common/src/test/resources/log4j2.properties:
##########
@@ -14,7 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-log4j.rootLogger=INFO, out
-log4j.appender.out=org.apache.log4j.ConsoleAppender
-log4j.appender.out.layout=org.apache.log4j.PatternLayout
-log4j.appender.out.layout.ConversionPattern=%d (%t) [%p - %l] %m%n
\ No newline at end of file
+rootLogger=INFO, out
Review Comment:
yeap, this pr has already merged, i will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org