You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/10 19:53:47 UTC

[GitHub] [pulsar] lhotari opened a new issue #8513: Flaky-test: cpp-test KeySharedConsumerTest

lhotari opened a new issue #8513:
URL: https://github.com/apache/pulsar/issues/8513


   cpp-test KeySharedConsumerTest.testMultiTopics is flaky
   
   [example failure](https://github.com/apache/pulsar/pull/8511/checks?check_run_id=1381552896#step:11:145)
   ```
    2020-11-10 19:25:34.191 INFO  [139997240441856] KeySharedConsumerTest:134 | messagesPerConsumer: {0 => 0, 1 => 529, 2 => 621}
   /pulsar/pulsar-client-cpp/tests/KeySharedConsumerTest.cc:137: Failure
   Expected: (fabs(count - expectedMessagesPerConsumer)) < (expectedMessagesPerConsumer * PERCENT_ERROR), actual: 383.333 vs 191.667
   ...
   [  FAILED  ] KeySharedConsumerTest.testMultiTopics (7096 ms)
   [----------] 1 test from KeySharedConsumerTest (7096 ms total)
   
   [----------] Global test environment tear-down
   [==========] 1 test from 1 test case ran. (7096 ms total)
   [  PASSED  ] 0 tests.
   [  FAILED  ] 1 test, listed below:
   [  FAILED  ] KeySharedConsumerTest.testMultiTopics
   ```
   
   cpp-test KeySharedConsumerTest.testOrderingKeyPriority is flaky
   
   [example failure](https://github.com/apache/pulsar/pull/8511/checks?check_run_id=1381552896#step:11:707)
   ```
   2020-11-10 19:30:30.986 INFO  [139745305013248] KeySharedConsumerTest:134 | messagesPerConsumer: {0 => 0, 1 => 270, 2 => 264}
   /pulsar/pulsar-client-cpp/tests/KeySharedConsumerTest.cc:137: Failure
   Expected: (fabs(count - expectedMessagesPerConsumer)) < (expectedMessagesPerConsumer * PERCENT_ERROR), actual: 178 vs 89
   ...
   [  FAILED  ] KeySharedConsumerTest.testOrderingKeyPriority (6435 ms)
   [----------] 1 test from KeySharedConsumerTest (6435 ms total)
   
   [----------] Global test environment tear-down
   [==========] 1 test from 1 test case ran. (6435 ms total)
   [  PASSED  ] 0 tests.
   [  FAILED  ] 1 test, listed below:
   [  FAILED  ] KeySharedConsumerTest.testOrderingKeyPriority
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower commented on issue #8513: Flaky-test: cpp-test KeySharedConsumerTest

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #8513:
URL: https://github.com/apache/pulsar/issues/8513#issuecomment-725402811


   It's introduced in #7487 , the flaky test is caused by the verification of key shared distribution like https://github.com/apache/pulsar/blob/61e62133a8d63210915e737c2affd6935fc3c528/pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java#L968-L973.
   
   Since C++ unit tests are running in parallel, I thought it may be easier to fail. (I'm not sure if Java tests were running in parallel)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui closed issue #8513: Flaky-test: cpp-test KeySharedConsumerTest

Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #8513:
URL: https://github.com/apache/pulsar/issues/8513


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on issue #8513: Flaky-test: cpp-test KeySharedConsumerTest

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #8513:
URL: https://github.com/apache/pulsar/issues/8513#issuecomment-725395097


   @BewareMyPower Could you please help take a look at this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower edited a comment on issue #8513: Flaky-test: cpp-test KeySharedConsumerTest

Posted by GitBox <gi...@apache.org>.
BewareMyPower edited a comment on issue #8513:
URL: https://github.com/apache/pulsar/issues/8513#issuecomment-725402811


   It's introduced in #7487 , the flaky test is caused by the verification of key shared distribution like https://github.com/apache/pulsar/blob/61e62133a8d63210915e737c2affd6935fc3c528/pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java#L968-L973.
   
   And the C++ implementation is https://github.com/apache/pulsar/blob/61e62133a8d63210915e737c2affd6935fc3c528/pulsar-client-cpp/tests/KeySharedConsumerTest.cc#L132-L138
   
   Since C++ unit tests are running in parallel, I thought it may be easier to fail. (I'm not sure if Java tests were running in parallel)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org