You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "thecoop (via GitHub)" <gi...@apache.org> on 2025/06/19 13:04:39 UTC
[PR] Convert some complex PriorityQueue implementations to comparators [lucene]
thecoop opened a new pull request, #14817:
URL: https://github.com/apache/lucene/pull/14817
A 3rd set of `PriorityQueue` conversions. These ones are more controversial, and so need some specific review and discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Convert some complex PriorityQueue implementations to comparators [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988043480
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Convert some complex PriorityQueue implementations to comparators [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988077064
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Convert some complex PriorityQueue implementations to comparators [lucene]
Posted by "thecoop (via GitHub)" <gi...@apache.org>.
thecoop commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988145555
The subclasses that are remaining after this PR are:
* `TermsMergeQueue`. This has some additional state in the `stack` variable
* `FieldValueHitQueue`. This is further subclassed, and is public (although experimental)
* `HitQueue`. Public class (although internal). Used in several difference places, so this class represents some common functionality.
* `TopDocs.ScoreMergeSortQueue`, `TopDocs.MergeSortQueue`. Has some significant state fields in them
* `TopOrdAndNumberQueue` and subclasses. Part of the public API, and has some abstract behavious set by subclasses
* `SuggestWordQueue`. Public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Convert some complex PriorityQueue implementations to comparators [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988081467
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org