You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ben Kietzman (Jira)" <ji...@apache.org> on 2020/12/15 19:06:00 UTC

[jira] [Commented] (ARROW-10922) [C++] Test utility PrintArrayDiff prints a different style when arrays differ in length

    [ https://issues.apache.org/jira/browse/ARROW-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249876#comment-17249876 ] 

Ben Kietzman commented on ARROW-10922:
--------------------------------------

Ideally the diff would consider a chunk boundary a different kind of symbol so that when comparing {{["alpha", "beta", "gamma"]}} and {{["alpha"], ["gamma"]}} we could see:
{code}
@@ -1, +1 @@
-"beta"
+<chunk boundary>
{code}

> [C++] Test utility PrintArrayDiff prints a different style when arrays differ in length
> ---------------------------------------------------------------------------------------
>
>                 Key: ARROW-10922
>                 URL: https://issues.apache.org/jira/browse/ARROW-10922
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Weston Pace
>            Priority: Trivial
>
> For example, when comparing (expected) `[1, 2, 3]` with (actual) `[1, 2]` I would expect something like...
>  
> Unequal at absolute position 2 <missing>
> Expected:
> - 2
> Actual:
> - <missing>
>  
> Instead, the message is "Expected length 3 but was actually 2"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)