[GitHub] [superset] nytai commented on a change in pull request #19231: chore!: remove `ENABLE_REACT_CRUD_VIEWS` feature flag (permanently enable)

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #19231:
URL: https://github.com/apache/superset/pull/19231#discussion_r829602155



##########
File path: tests/integration_tests/core_tests.py
##########
@@ -429,6 +429,7 @@ def test_slices(self):
             self.assertEqual(resp.status_code, 200)
 
     def test_tablemodelview_list(self):
+        pytest.skip("Depends on ENABLE_REACT_CRUD_VIEWS=False")

Review comment:
       I don't think there's any real loss of coverage here. `ENABLE_REACT_CRUD_VIEWS=True` has been the case for most large deployment of superset so far, so these test are just covering functionality that no one is using. The api tests and js tests provide decent coverage for the new crud view, imo. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org