You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2024/10/31 13:14:10 UTC

[PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

stoty opened a new pull request, #257:
URL: https://github.com/apache/calcite-avatica/pull/257

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257#issuecomment-2449899549

   should work when rebased on top of #260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257#issuecomment-2469757474

   Rebasing on top of #260 only does not help.
   Is some other plugin forcing an asm downgrade ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257#issuecomment-2470077333

   Technically, we have two mechanisms:
   - The constraints for the project ( not build), are applied by the property reading magic.
   - We have a block for applying the constraints for the spotbug plugins only.
   
   There is nothing that that would apply to the shadowJar plugin.
   
   The mechanism used for overriding the constraints does not work for shadowJar plugin, but we can just add the constraint globall to the build environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty merged PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257#issuecomment-2449880086

   This did not fail for me when testing the upgrades together.
   Possibly the checkstyle update pulls in a new enough asm jar ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #257:
URL: https://github.com/apache/calcite-avatica/pull/257#issuecomment-2469856585

   The problem is that the current asm version constraints apply to the code buing built, but they do not apply to the plugins itself.
   
   Asm is only used in tests by kerby, and it doesn't seem to cause a problem, it may even be necessary, so I wouldn't touch that, but we definitely need to add the constraint for the shadow plugin.
   
   No why it worked for me when I first tested it, probably I made some mistake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org