[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

["James E. King, III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189786#comment-16189786 ] 

James E. King, III commented on THRIFT-4350:
--------------------------------------------

I'd appreciate some feedback on this pull request.  It sets the bar rather high, and the server based cross tests are not working, but it brings client tests into make cross and brings the project up to supporting the official dotnet 2.0 release.  I think it's a step forward overall, but I need to know if the step is too far forward.  I tried backing off to .NET core 1.1 but it wasn't trivial so that's why I left everything at the 2.0 language level in this PR.

> Update netcore build for dotnet 2.0 sdk and make cross validation
> -----------------------------------------------------------------
>
>                 Key: THRIFT-4350
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4350
>             Project: Thrift
>          Issue Type: Improvement
>          Components: .NETCore - Library
>    Affects Versions: 0.10.0
>         Environment: docker ubuntu-xenial
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project that is checked in
> # Ensure one can build on Linux using the project that is checked in and use make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)