You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/02 00:37:50 UTC
[PR] chore(amber): remove the unused search-by-operators endpoint [texera]
aglinxinyuan opened a new pull request, #8331:
URL: https://github.com/apache/texera/pull/8331
### What changes were proposed in this PR?
Deletes `WorkflowResource.searchWorkflowByOperator` (`GET /workflow/search-by-operators`), which has no client. Pure deletion, no behaviour change: **−66 lines**.
Workflow search in the UI goes to the unified `/dashboard/search` resource — the frontend's search service builds `${API}/dashboard/search`, and no file references this path.
**Provenance.** Introduced by #1611 (2022-08-07, "Search Workflows Feature") and genuinely used at the time: the frontend held `WORKFLOW_OPERATOR_URL = WORKFLOW_BASE_URL + "/search-by-operators"` and called it. #2038 (2023-07-07, "Allow users to cascade the sharing") deleted that constant when search moved to the dashboard resource; from that commit on, the only file mentioning the path is the backend resource itself. Dead for about three years.
> Reviewer note: the frontend's `searchByOperators` test in `user-workflow.component.spec.ts` is a name coincidence, not a caller — it drives the filter UI (`component.filters.operators`, `masterFilterList`), which queries `/dashboard/search`. Nothing in the frontend, or anywhere else, builds this URL.
Removing the method also frees `Condition` and `noCondition`, which no other method in `WorkflowResource` uses — scalafix flagged both, and they are the only other lines touched.
### Any related issues, documentation, discussions?
Closes #8328
### How was this PR tested?
Existing tests only — this PR adds none, since it removes an endpoint and the one test that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success.
- `sbt "WorkflowExecutionService/testOnly *WorkflowResourceSpec"` — 80 tests, all pass.
- `sbt scalafmtCheckAll "scalafixAll --check"` — clean.
Verification, re-runnable by a reviewer:
```
git grep -rn "search-by-operators\|searchWorkflowByOperator" # only the deleted method and its test
git grep -rn "dashboard/search" -- frontend/src # where search actually goes
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(amber): remove the unused search-by-operators endpoint [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8331:
URL: https://github.com/apache/texera/pull/8331#issuecomment-5502656001
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8331?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.05%. Comparing base ([`fc7cfcd`](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`40255f7`](https://app.codecov.io/gh/apache/texera/commit/40255f7c3d2337b975608759ac98e89ef558f0b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8331 +/- ##
============================================
- Coverage 94.07% 94.05% -0.02%
+ Complexity 4814 4810 -4
============================================
Files 1196 1196
Lines 48713 48698 -15
Branches 5866 5866
============================================
- Hits 45825 45804 -21
- Misses 1436 1439 +3
- Partials 1452 1455 +3
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.08% <ø> (-0.05%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.00% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.80% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.18% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [fc7cfcd](https://app.codecov.io/gh/apache/texera/commit/fc7cfcd9e14a68b43484a4d9ba923715076798f5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8331?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(amber): remove the unused search-by-operators endpoint [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8331:
URL: https://github.com/apache/texera/pull/8331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(amber): remove the unused search-by-operators endpoint [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8331:
URL: https://github.com/apache/texera/pull/8331#issuecomment-5502618614
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 6 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `fc7cfcd` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33576117730)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 356 | 0.217 | 27,106/36,705/36,705 us | 🔴 +20.6% / 🔴 +130.8% |
| 🔴 | bs=100 sw=10 sl=64 | 782 | 0.477 | 125,687/158,780/158,780 us | 🔴 +5.5% / 🔴 +43.5% |
| ⚪ | bs=1000 sw=10 sl=64 | 917 | 0.559 | 1,089,118/1,202,710/1,202,710 us | ⚪ within ±5% / 🔴 +14.1% |
<details><summary>Baseline details</summary>
Latest main `fc7cfcd` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 356 tuples/sec | 415 tuples/sec | 750.65 tuples/sec | -14.2% | -52.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.217 MB/s | 0.253 MB/s | 0.458 MB/s | -14.2% | -52.6% |
| bs=10 sw=10 sl=64 | p50 | 27,106 us | 22,485 us | 13,049 us | +20.6% | +107.7% |
| bs=10 sw=10 sl=64 | p95 | 36,705 us | 34,483 us | 15,902 us | +6.4% | +130.8% |
| bs=10 sw=10 sl=64 | p99 | 36,705 us | 34,483 us | 19,184 us | +6.4% | +91.3% |
| bs=100 sw=10 sl=64 | throughput | 782 tuples/sec | 815 tuples/sec | 960.3 tuples/sec | -4.0% | -18.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.477 MB/s | 0.498 MB/s | 0.586 MB/s | -4.2% | -18.6% |
| bs=100 sw=10 sl=64 | p50 | 125,687 us | 119,165 us | 104,199 us | +5.5% | +20.6% |
| bs=100 sw=10 sl=64 | p95 | 158,780 us | 156,648 us | 110,645 us | +1.4% | +43.5% |
| bs=100 sw=10 sl=64 | p99 | 158,780 us | 156,648 us | 120,888 us | +1.4% | +31.3% |
| bs=1000 sw=10 sl=64 | throughput | 917 tuples/sec | 898 tuples/sec | 993.27 tuples/sec | +2.1% | -7.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.559 MB/s | 0.548 MB/s | 0.606 MB/s | +2.0% | -7.8% |
| bs=1000 sw=10 sl=64 | p50 | 1,089,118 us | 1,111,019 us | 1,012,191 us | -2.0% | +7.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,202,710 us | 1,222,388 us | 1,054,057 us | -1.6% | +14.1% |
| bs=1000 sw=10 sl=64 | p99 | 1,202,710 us | 1,222,388 us | 1,081,313 us | -1.6% | +11.2% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,562.56,200,128000,356,0.217,27105.93,36705.22,36705.22
1,100,10,64,20,2556.66,2000,1280000,782,0.477,125687.48,158780.29,158780.29
2,1000,10,64,20,21818.69,20000,12800000,917,0.559,1089117.93,1202710.42,1202710.42
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(amber): remove the unused search-by-operators endpoint [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8331:
URL: https://github.com/apache/texera/pull/8331#issuecomment-5502567635
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@yangzhang75`
You can notify them by mentioning `@yangzhang75` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org