[GitHub] [ambari] virajjasani commented on a diff in pull request #3431: AMBARI-25198. MYSQL connector exception while upgrading Ambari

[GitBox <gi...@apache.org>]

virajjasani commented on code in PR #3431:
URL: https://github.com/apache/ambari/pull/3431#discussion_r1008937587


##########
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java:
##########
@@ -76,6 +77,11 @@
 @Singleton
 public class DBAccessorImpl implements DBAccessor {
   private static final Logger LOG = LoggerFactory.getLogger(DBAccessorImpl.class);
+  public static final String USER = "user";
+  public static final String PASSWORD = "password";
+  public static final String NULL_CATALOG_MEANS_CURRENT = "nullCatalogMeansCurrent";
+  public static final String TRUE = "true";
+  public static final int SUPPORT_CONNECTOR_VERSION = 5;

Review Comment:
   For the forward-port purpose, this is good but otherwise we can make them all private in separate commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org