[Bug 7895] New: No X-Spam-ASN tag for 3.4

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7895

            Bug ID: 7895
           Summary: No X-Spam-ASN tag for 3.4
           Product: Spamassassin
           Version: 3.4.5
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: mail@maciej.szmigiero.name
  Target Milestone: Undefined

There is no longer a "X-Spam-ASN" tag present with SA 3.4 (at least with
3.4.5), even when the ASN plugin is enabled.

This issue is likely caused by SVN commit 1877554 ("Use new check_asn()
function instead of X-ASN metadata in rules (Bug 7791))" (git commit
522fec3a4073c), since it introduced a check in "rules/25_asn.cf" for presence
of "has_check_asn" in the ASN plugin before performing an automatic ASN lookup.

"has_check_asn" is not present in the ASN plugin in 3.4 branch, but the comment
above that check in "rules/25_asn.cf" suggests the intention was to disable the
automatic ASN lookup only for 4.0 branch, that is, opposite what the code
actually does.

In fact, when I reverse that "has_check_asn" condition in "rules/25_asn.cf" the
"X-Spam-ASN" header returns.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7895] No X-Spam-ASN tag for 3.4

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7895

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apache@hege.li

--- Comment #1 from Henrik Krohns <ap...@hege.li> ---
My bad, fixed. Apparently not many people looked for it. :-)

Sending        rules/25_asn.cf
Transmitting file data .done
Committing transaction...
Committed revision 1888168.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7895] No X-Spam-ASN tag for 3.4

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7895

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
... and resolving.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7895] No X-Spam-ASN tag for 3.4

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7895

Maciej S. Szmigiero <ma...@maciej.szmigiero.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@maciej.szmigiero.name

--- Comment #3 from Maciej S. Szmigiero <ma...@maciej.szmigiero.name> ---
Thanks Henrik.

-- 
You are receiving this mail because:
You are the assignee for the bug.