[GitHub] [maven-apache-parent] kwin commented on a change in pull request #40: MPOM-244 upload SHA512 to staging repo as well

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #40:
URL: https://github.com/apache/maven-apache-parent/pull/40#discussion_r625312958



##########
File path: pom.xml
##########
@@ -441,31 +441,26 @@ under the License.
           <plugin>
             <groupId>net.nicoulaj.maven.plugins</groupId>
             <artifactId>checksum-maven-plugin</artifactId>
-            <version>1.9</version>
+            <version>1.10</version>
             <executions>
               <execution>
                 <id>source-release-checksum</id>
                 <goals>
-                  <goal>files</goal>
+                  <goal>artifacts</goal>
                 </goals>
+                <configuration>
+                  <algorithms>
+                    <algorithm>SHA-512</algorithm>
+                  </algorithms>
+                  <!-- https://maven.apache.org/apache-resource-bundles/#source-release-assembly-descriptor -->
+                  <includeClassifiers>source-release,source-release-tar</includeClassifiers>

Review comment:
       My bad, I think all descriptors use the same classifier (https://github.com/apache/maven-resources/blob/e9eaa1baebb72795555eba015eac9b40f288e931/apache-source-release-assembly-descriptor/src/main/assemblies/source-release.xml#L22)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org