You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kute <gi...@git.apache.org> on 2017/06/06 09:27:47 UTC

[GitHub] spark pull request #18214: fix param dismatch when using makeRDD

GitHub user kute opened a pull request:

    https://github.com/apache/spark/pull/18214

    fix param dismatch when using makeRDD

    when i see at : http://spark.apache.org/docs/latest/sql-programming-guide.html#schema-merging, 
    
    ```
    val squaresDF = spark.sparkContext.makeRDD(1 to 5).map(i => (i, i * i)).toDF("value", "square")
    squaresDF.write.parquet("data/test_table/key=1")
    ```
    
    
    
    this will be error on jobs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kute/spark patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18214
    
----
commit a1089452e75b6e1ddbcc918f3b79d214d9b4820c
Author: kute <ku...@gmail.com>
Date:   2017-06-06T09:26:32Z

    fix param dismatch when using makeRDD
    
    when i see at : http://spark.apache.org/docs/latest/sql-programming-guide.html#schema-merging, 
    
        val squaresDF = spark.sparkContext.makeRDD(1 to 5).map(i => (i, i * i)).toDF("value", "square")
    
    
    this will be error on jobs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18214: fix param dismatch when using makeRDD

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18214
  
    I don't immediately see the problem with the existing example. It makes an RDD then maps the values. Your example maps the values then makes the RDD. It ought to be equivalent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18214: fix param dismatch when using makeRDD

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18214
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18214: fix param dismatch when using makeRDD

Posted by kute <gi...@git.apache.org>.
Github user kute commented on the issue:

    https://github.com/apache/spark/pull/18214
  
    Yes, it is right when I use in spark-shell. It ought to be equivalent indeed, maybe something about library or path in IDEA. Thanks a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18214: fix param dismatch when using makeRDD

Posted by kute <gi...@git.apache.org>.
Github user kute closed the pull request at:

    https://github.com/apache/spark/pull/18214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org