You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/01/03 15:27:43 UTC
[PR] GH-39273: [R] Add character to dictionary conversion path [arrow]
paleolimbot opened a new pull request, #39443:
URL: https://github.com/apache/arrow/pull/39443
### Rationale for this change
Converting a `character()` with explicit type `dictionary()` currently fails and dictionary-encoding is a common optimization
### What changes are included in this PR?
"Just pop a `as.factor()` in there", except harder because the conversion code is highly templated C++.
### Are these changes tested?
Covered by existsing tests.
### Are there any user-facing changes?
Yes, a new conversion pathway is exposed (although requires explicit user intervention to invoke the new feature).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39273: [R] Add character to dictionary conversion path [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39443:
URL: https://github.com/apache/arrow/pull/39443#issuecomment-1875550598
:warning: GitHub issue #39273 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39273: [R] Add character to dictionary conversion path [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed pull request #39443: GH-39273: [R] Add character to dictionary conversion path
URL: https://github.com/apache/arrow/pull/39443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39273: [R] Add character to dictionary conversion path [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #39443:
URL: https://github.com/apache/arrow/pull/39443#issuecomment-2163704416
Closing since I don't have the time to debug the segfault that this introduced!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org