You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Raghav Gautam <ra...@apache.org> on 2014/11/18 22:54:57 UTC

Review Request 28185: Add option to dump xmls generated by falcon

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28185/
-----------------------------------------------------------

Review request for Falcon.


Bugs: falcon-884
    https://issues.apache.org/jira/browse/falcon-884


Repository: falcon-git


Description
-------

Add option to dump xmls generated by falcon


Diffs
-----

  falcon-regression/README.md abfa689 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 354137c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java ee0c072 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Config.java 9172455 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java e3af96d 

Diff: https://reviews.apache.org/r/28185/diff/


Testing
-------

Tested manually and feature works as expected.


Thanks,

Raghav Gautam


Re: Review Request 28185: Add option to dump xmls generated by falcon

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28185/#review63358
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java
<https://reviews.apache.org/r/28185/#comment105579>

    Array should contain trailing comma.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java
<https://reviews.apache.org/r/28185/#comment105580>

    logger -> LOGGER


- Ruslan Ostafiychuk


On Nov. 18, 2014, 9:54 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28185/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 9:54 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-884
>     https://issues.apache.org/jira/browse/falcon-884
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add option to dump xmls generated by falcon
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md abfa689 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 354137c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java ee0c072 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Config.java 9172455 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java e3af96d 
> 
> Diff: https://reviews.apache.org/r/28185/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and feature works as expected.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Re: Review Request 28185: Add option to dump xmls generated by falcon

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28185/#review64006
-----------------------------------------------------------

Ship it!


Ship It!

- Ruslan Ostafiychuk


On Dec. 4, 2014, 1:53 a.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28185/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 1:53 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-884
>     https://issues.apache.org/jira/browse/falcon-884
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add option to dump xmls generated by falcon
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md eca1ca0 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 354137c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java f70b8f5 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Config.java 9172455 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 645d63b 
> 
> Diff: https://reviews.apache.org/r/28185/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and feature works as expected.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Re: Review Request 28185: Add option to dump xmls generated by falcon

Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28185/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 5:53 p.m.)


Review request for Falcon.


Bugs: falcon-884
    https://issues.apache.org/jira/browse/falcon-884


Repository: falcon-git


Description
-------

Add option to dump xmls generated by falcon


Diffs (updated)
-----

  falcon-regression/README.md eca1ca0 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 354137c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java f70b8f5 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Config.java 9172455 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 645d63b 

Diff: https://reviews.apache.org/r/28185/diff/


Testing
-------

Tested manually and feature works as expected.


Thanks,

Raghav Gautam