[GitHub] [spark] zwangsheng commented on a diff in pull request #42600: [SPARK-44906][K8S] Make `Kubernetes[Driver|Executor]Conf.annotations` substitute annotations instead of feature steps

["zwangsheng (via GitHub)" <gi...@apache.org>]

zwangsheng commented on code in PR #42600:
URL: https://github.com/apache/spark/pull/42600#discussion_r1302507782


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala:
##########
@@ -117,6 +117,7 @@ private[spark] class KubernetesDriverConf(
 
   override def annotations: Map[String, String] = {
     KubernetesUtils.parsePrefixedKeyValuePairs(sparkConf, KUBERNETES_DRIVER_ANNOTATION_PREFIX)
+      .map(p => (p._1, Utils.substituteAppNExecIds(p._2, appId, "")))

Review Comment:
   Sorry,  i misunderstood `the consistent short style`.
   
   Does the following code conform
   ```
   .map{ case(k, v) => (k, Utils.substituteAppNExecIds(v, appId, executorId)) }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org