You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicemix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2008/05/16 14:37:45 UTC

[jira] Commented: (SM-1349) SimpleFlatFileMarshaler runs out of memory on big files

    [ https://issues.apache.org/activemq/browse/SM-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42820#action_42820 ] 

Guillaume Nodet commented on SM-1349:
-------------------------------------

The patch really looks awesome.  I don't have time right now to check it in, but it's definitely worth it, thx a lot !

> SimpleFlatFileMarshaler runs out of memory on big files
> -------------------------------------------------------
>
>                 Key: SM-1349
>                 URL: https://issues.apache.org/activemq/browse/SM-1349
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-core
>    Affects Versions: 3.2.2, 3.3
>            Reporter: Andrew Skiba
>             Fix For: 3.2.2, 3.3
>
>         Attachments: sffm.patch, sffm_test.patch
>
>
> unlike DefaultFileMarshaler, SimpleFlatFileMarshaler creates the whole resulting XML in memory. This causes out of memory exception. See the test case and the fix in the attachments.
> The idea is to wrap the input stream, so the conversion is done line-by-line when (and if) the normalized message content is read. Attention is payed to keep backward compatibility so protected members behave the same.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.