[jira] [Commented] (MASSEMBLY-966) Artifacts with classifiers are not included anymore

["Jared Stehler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MASSEMBLY-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690529#comment-17690529 ] 

Jared Stehler commented on MASSEMBLY-966:
-----------------------------------------

i am seeing this with 3.4.0 and 3.4.2, trying to include the attached shaded artifact as `*:jar:shaded`

> Artifacts with classifiers are not included anymore
> ---------------------------------------------------
>
>                 Key: MASSEMBLY-966
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-966
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: dependencySet, filtering
>    Affects Versions: 3.4.0
>            Reporter: Thomas Mortagne
>            Priority: Critical
>
> I just upgraded to 3.4.0 (from 3.3.0) and one of my dependencies with a classifier and supposed to be included is now skipped. I guess it's a consequence of MASSEMBLY-955.
> In the pom the dependency is declared with
> {code:xml}
>     <dependency>
>       <groupId>org.eclipse.jetty</groupId>
>       <artifactId>jetty-start</artifactId>
>       <version>10.0.7</version>
>       <classifier>shaded</classifier>
>       <optional>true</optional>
>     </dependency>
> {code}
> and assembly configuration looks like
> {code:xml}
> <assembly>
>   <id>distribution</id>
>   <formats>
>     <format>zip</format>
>   </formats>
>   <includeBaseDirectory>false</includeBaseDirectory>
>   <dependencySets>
>     <dependencySet>
>       <outputFileNameMapping>start.jar</outputFileNameMapping>
>       <outputDirectory>/jetty</outputDirectory>
>       <includes>
>         <include>org.eclipse.jetty:jetty-start:jar:shaded</include>
>       </includes>
>     </dependencySet>
> [...]
>   </dependencySets>
> [...]
> </assembly>
> {code}
> And I see the related warning in the log:
> {code:xml}
> [INFO] --- maven-assembly-plugin:3.4.0:single (default) @ xwiki-platform-tool-jetty-resources ---
> [INFO] Reading assembly descriptor: /media/DATA/xwiki/sources/xwiki-platform/xwiki-platform-tools/xwiki-platform-tool-jetty/xwiki-platform-tool-jetty-resources/src/main/assembly/distribution.xml
> [WARNING] The following patterns were never triggered in this artifact inclusion filter:
> o  'org.eclipse.jetty:jetty-start:jar:shaded'
> [WARNING] The following patterns were never triggered in this artifact exclusion filter:
> o  'org.eclipse.jetty:jetty-start:jar:shaded'
> {code}
> For more details the module can be found on https://github.com/xwiki/xwiki-platform/tree/xwiki-platform-14.5/xwiki-platform-tools/xwiki-platform-tool-jetty/xwiki-platform-tool-jetty-resources.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)