You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 22:35:24 UTC
[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #2918:
[GOBBLIN-1079] set extract.is.full property
arjun4084346 opened a new pull request #2918: [GOBBLIN-1079] set extract.is.full property
URL: https://github.com/apache/incubator-gobblin/pull/2918
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@yukuai518 please review
### JIRA
- [x] My PR addresses the following [Gobblin-1079](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
a new pull job that pulls from file based source S3 with snapshot_only extract type.
But the job is still writing the output as _append instead of _full .
this PR will use the appropriate configs so the output path is correctly calculated.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
trivial changes
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] yukuai518 commented on issue #2918:
[GOBBLIN-1079] set extract.is.full property
Posted by GitBox <gi...@apache.org>.
yukuai518 commented on issue #2918: [GOBBLIN-1079] set extract.is.full property
URL: https://github.com/apache/incubator-gobblin/pull/2918#issuecomment-597861665
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2918:
[GOBBLIN-1079] set extract.is.full property
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2918: [GOBBLIN-1079] set extract.is.full property
URL: https://github.com/apache/incubator-gobblin/pull/2918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services