You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/24 20:51:54 UTC
[GitHub] [camel-quarkus-examples] zbendhiba opened a new pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
zbendhiba opened a new pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65
Note that the `main` branch points at the latest stable Camel Quarkus release.
Pull requests should be generally send against the `camel-quarkus-main` branch pointing at the current Camel Quarkus SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] zbendhiba commented on pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65#issuecomment-978979710
@ppalaga it should be fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] ppalaga commented on a change in pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65#discussion_r756696768
##########
File path: aws-lambda/pom.xml
##########
@@ -21,13 +21,13 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.camel.quarkus.examples</groupId>
<artifactId>camel-quarkus-examples-aws-lambda</artifactId>
- <version>2.4.0</version>
+ <version>2.5.0-SNAPSHOT</version>
Review comment:
Indeed, the tag commit comes after the PR in the docs. Sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] ppalaga merged pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] ppalaga commented on a change in pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65#discussion_r756421475
##########
File path: aws-lambda/pom.xml
##########
@@ -21,13 +21,13 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.camel.quarkus.examples</groupId>
<artifactId>camel-quarkus-examples-aws-lambda</artifactId>
- <version>2.4.0</version>
+ <version>2.5.0-SNAPSHOT</version>
Review comment:
This should either be 2.5.0 or you maybe want to make as separate commit to tag 2.5.0 of the examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] ppalaga commented on a change in pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65#discussion_r756421475
##########
File path: aws-lambda/pom.xml
##########
@@ -21,13 +21,13 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.camel.quarkus.examples</groupId>
<artifactId>camel-quarkus-examples-aws-lambda</artifactId>
- <version>2.4.0</version>
+ <version>2.5.0-SNAPSHOT</version>
Review comment:
This should either be 2.5.0 or you maybe want to make a separate commit to tag 2.5.0 of the examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] zbendhiba commented on a change in pull request #65: Upgrade to Quarkus Platform 2.5.0.Final
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #65:
URL: https://github.com/apache/camel-quarkus-examples/pull/65#discussion_r756634875
##########
File path: aws-lambda/pom.xml
##########
@@ -21,13 +21,13 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.camel.quarkus.examples</groupId>
<artifactId>camel-quarkus-examples-aws-lambda</artifactId>
- <version>2.4.0</version>
+ <version>2.5.0-SNAPSHOT</version>
Review comment:
Yes that was you who wrote the doc 🤣
I was going to suggest changing that part. Let me update this and also the release guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org