[GitHub] [flink] rkhachatryan commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

[GitBox <gi...@apache.org>]

rkhachatryan commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r425315334



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -182,7 +181,7 @@
 	protected final TimerService timerService;
 
 	/** The currently active background materialization threads. */
-	private final CloseableRegistry cancelables = new CloseableRegistry();
+	private final AsyncCheckpointRunnableRegistry cancelables = new AsyncCheckpointRunnableRegistry();

Review comment:
       > we still need something to warp them all.
   
   Do you mean a scenario when all runnables need to be closed? 
   For this we can explicitly iterate over a map and close them in `SubtaskCheckpointCoordinatorImpl.close()` (it's already registered with `closeableRegistry`).
   
   
   > it's not easy to avoid passing registry
   
   I didn't mean we should do it now but it's one thing we can consider in future. Having it tied to runnables makes it a bit harder.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org