You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2026/05/11 20:37:11 UTC
[PR] Moved About modal to overview page [accumulo]
dlmarion opened a new pull request, #6366:
URL: https://github.com/apache/accumulo/pull/6366
Moved the information in the About model page
to the overview page. Increased the font size
on the overview table.
Closes #6365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4424975832
Need to figure out how to add a loading spinner to instance information card and fix the vertical alignment in the deployment overview table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4441729182
I backed out the changes to try and make the deployment table contents larger. Created #6368 to try and fix it in a different issue. Current screen shot of the changes in this PR:
<img width="955" height="509" alt="InstanceCard2" src="https://github.com/user-attachments/assets/e90c536a-195a-4ebf-b595-314dc3fc5f40" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#discussion_r3236156953
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/overview.js:
##########
@@ -35,7 +41,10 @@ $(function () {
* Makes the REST calls, generates the table with the new information
*/
function refreshOverview() {
- refreshDeploymentTables();
+ $.when(getInstanceInfo(), getDeployment()).then(function () {
+ refreshInstanceInfo();
+ refreshDeploymentTables();
+ });
Review Comment:
```suggestion
getInstanceInfo().then(function () {
refreshInstanceInfo();
});
getDeployment().then(function () {
refreshDeploymentTables();
});
```
I think we should separate these calls so if one fails it does not block the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4441286286
Look at the overview page with the instance card. I made the overview table font size larger in a prior commit and now the vertical alignment of the numbers in the pills is off.
<img width="1053" height="618" alt="InstanceCard" src="https://github.com/user-attachments/assets/5e802305-ce39-4927-9a0d-bb20eaba4a85" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4450362304
> I'm very strongly -1 for moving this "About" information to the main overview page, just to make it less light on content. I don't think we need to try to fill the space just to fill it, and I think the About page is better to have off to the side.
It wasn't moved solely because the overview page was light on content. The suggestion was made to change the three-dot menu icon to a gear icon and make it a preferences menu. It didn't make sense to me to have the About menu item in the preference menu. What I have seen in most UIs is that the About page is located off some Help menu (Help -> About).
> I would prefer model stay, but the preferences be added to it.
I feel like that is odd, I don't know that I have ever seen an implementation of this.
> It's nice to have a modal preferences window, and the information in the About modal can be shown there. It doesn't need to be added to the Overview page. I'm in favor of reverting this, or moving it back to a modal for the preferences.
I can revert this change and move the About back to the three-dot menu. In PR #6369 the About link will show up in the preference menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4454225364
> It didn't make sense to me to have the About menu item in the preference menu.
I agree, but I was thinking that instead of having preferences be a menu, it could be a modal, with the about details inside that model (not as a separate link), to consolidate the two.
> What I have seen in most UIs is that the About page is located off some Help menu (Help -> About).
Same, but we don't have a general help, so we need to do something a little different.
>
> > I would prefer model stay, but the preferences be added to it.
>
> I feel like that is odd, I don't know that I have ever seen an implementation of this.
My idea is roughly modeled after other "settings" pages that I've seen that have some system details alongside some system options. This is common for many UIs:
* system BIOS menus
* Windows' "About" app also displays system details and system specifications intermixed with options (like changing the hostname or configuring the activation/license/owner details)
* RHEL has a similar "About" page in its settings app that shows static info alongside some configurable preferences
* some GitHub pages, like `https://github.com/organizations/<org>/settings/packages` have settings alongside state information (in this example, the settings are package permissions, while the state is a list of deleted packages)
* The GNOME Shell Calendar/Notification UI, which shows static (and navigable) calendar and notifications info, but also has preferences like a "Do Not Disturb" toggle.
* The modal window for creating a new issue in GitHub has the input areas, but also has static informational links at the bottom to the target repo's contributor guide, security policy, and code of conduct.
So, we can certainly do something similar, having some basic static state (information about the system) alongside preferences inputs.
I was thinking a simple modal, something like the following outline:
```
----------------- About --------------------
Instance Id: xxxxxxx Version: 1.2.3
ZooKeepers: host1:port,...
-------------- Preferences -----------------
Option 1: [ ] Option 2: [x]
Option 3: [x] Option 4: [x]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4446615215
I'm very strongly -1 for moving this "About" information to the main overview page, just to make it less light on content. I don't think we need to try to fill the space just to fill it, and I think the About page is better to have off to the side. I would prefer model stay, but the preferences be added to it. It's nice to have a modal preferences window, and the information in the About modal can be shown there. It doesn't need to be added to the Overview page. I'm in favor of reverting this, or moving it back to a modal for the preferences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6366:
URL: https://github.com/apache/accumulo/pull/6366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved About modal to overview page [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #6366:
URL: https://github.com/apache/accumulo/pull/6366#issuecomment-4454237145
This was reverted in 515a7f12a8966cbc2367c35af6b1e05d3ca62e04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org