You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2017/12/28 17:54:41 UTC

[GitHub] flink pull request #5213: [docs][metrics] Fix typo of metrics docs

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/5213

    [docs][metrics] Fix typo of metrics docs

    ## What is the purpose of the change
    1. Fix typo of Threads.Count metric in docs.
    2. Fix `Liquid Exception: highlight tag was never closed in  monitoring/metrics.md` by removing unnecessary `{% highlight java %}` Liquid tag. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink fix_docs_metric_threads_count

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5213
    
----
commit 2f056b02a83331248b64c65c393ba7934a4278f0
Author: yew1eb <ye...@...>
Date:   2017-12-28T17:15:40Z

    [docs][metrics] Fix typo on Threads.Count metric

----


---

[GitHub] flink issue #5213: [Minor][docs][metrics] Fix typo of metrics docs

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5213
  
    merging.


---

[GitHub] flink pull request #5213: [Minor][docs][metrics] Fix typo of metrics docs

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5213#discussion_r159523422
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -905,7 +903,7 @@ Thus, in order to infer the metric identifier:
       <tbody>
         <tr>
           <th rowspan="1"><strong>Job-/TaskManager</strong></th>
    -      <td rowspan="1">Status.JVM.ClassLoader</td>
    +      <td rowspan="1">Status.JVM</td>
    --- End diff --
    
    Infix as `Status.JVM.Threads` and Metrics as `Count`?


---

[GitHub] flink pull request #5213: [Minor][docs][metrics] Fix typo of metrics docs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5213


---