You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 16:00:12 UTC

[GitHub] [airflow] potiuk opened a new pull request #18093: Workaround Flask-OpenId failure with recent setuptools update

potiuk opened a new pull request #18093:
URL: https://github.com/apache/airflow/pull/18093


   As of 6th of September 2021, setuptools released 50.0.2 followed by
   50.0.3 release - both of which fail Flask-OpenId installation.
   
   This broken Airflow installation. It's been workarounded for released
   version of Airflow by publishing patched version of FlaskOpenID in
   Airflow GitHub repository. This change adapts our main and
   constraint generation to include automated generation of
   the special Flask-OpenId dependency.
   
   With this change:
   
   1) Setuptools is pinned to 50.0.3 (to make sure our builds
      work with that version - this can also give us more control
      in the future.
   
   2) Flask-OpenID is installed explicitly before airflow is installed
      when eager-upgrade is used
   
   Closes: #18075
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18093: Workaround Flask-OpenId failure with recent setuptools update

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18093:
URL: https://github.com/apache/airflow/pull/18093#issuecomment-915610092


   No need to workaround it. I became Flask-OpenID maintainer and  released 1.3.0 version in PyPI and we are back to normal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18093: Workaround Flask-OpenId failure with recent setuptools update

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18093:
URL: https://github.com/apache/airflow/pull/18093#issuecomment-915366522


   Note ! We might not need it. We are talking with @dgaspar about other ways of solving the problem permanently (as Superset needs another solution). I just wanted to open it, in case we need it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed pull request #18093: Workaround Flask-OpenId failure with recent setuptools update

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #18093:
URL: https://github.com/apache/airflow/pull/18093


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org