You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@collab.net> on 2005/01/18 21:53:44 UTC

Two DAV problems/questions.

I'm busy teaching ra_dav to use/send lock tokens when committing.

First:  after building a repository transaction (Delta V "activity"), 
the svn client performs the final commit by sending a MERGE request 
whose source is the activity.  This causes all of our checked-out 
working-resources to be "auto-checked-in".  But does this have any 
effect on locks attached to these resources?  My guess is "no" -- after 
the MERGE, the locks still remain by default.  Is that correct?

Second:  this final MERGE request needs to send every lock token that 
was attached to every committed file.  According to spec, this is 
normally done in the "If:" header.  But apache has an 8K length limit 
per request header.  Given that our tokens are about 56 bytes long, 
that means a hard limit of about 130 locks.  This is a real problem;  
it's easy to conceive of a large commit uploading changes to more than 
130 locked files.  What can we do here?

        --> can mod_dav_svn temporarily turn off the limitation on the 
length of the If: header?

        --> if not, can we send the tokens in custom XML in the request 
body?  Does the DeltaV spec allow that?  Even worse, will that break a 
1.0 server?


(In the absolute worst-case scenario, I guess an svn 1.2 client can 
always invent a new REPORT request as a way of performing the final 
commit.  If an older server returns a "report request not recognized" 
error, the client could retry a MERGE request without tokens.  Is it 
even a plausible scenario that an svn client might be managing tokens 
in a working copy, and trying to commit to a 1.0 server?)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Two DAV problems/questions.

Posted by Julian Reschke <ju...@gmx.de>.
Ben Collins-Sussman wrote:
> I'm busy teaching ra_dav to use/send lock tokens when committing.
> 
> First:  after building a repository transaction (Delta V "activity"), 
> the svn client performs the final commit by sending a MERGE request 
> whose source is the activity.  This causes all of our checked-out 
> working-resources to be "auto-checked-in".  But does this have any 
> effect on locks attached to these resources?  My guess is "no" -- after 
> the MERGE, the locks still remain by default.  Is that correct?

DeltaV (RFC3253) and WebDAV locks are completely orthogonal concepts. 
Thus: "no" (yes, you are correct).

> Second:  this final MERGE request needs to send every lock token that 
> was attached to every committed file.  According to spec, this is 
> normally done in the "If:" header.  But apache has an 8K length limit 
> per request header.  Given that our tokens are about 56 bytes long, that 
> means a hard limit of about 130 locks.  This is a real problem;  it's 
> easy to conceive of a large commit uploading changes to more than 130 
> locked files.  What can we do here?
> 
>        --> can mod_dav_svn temporarily turn off the limitation on the 
> length of the If: header?
> 
>        --> if not, can we send the tokens in custom XML in the request 
> body?  Does the DeltaV spec allow that?  Even worse, will that break a 
> 1.0 server?

RFC2518bis updates the syntax for the "If" header so that it can be 
split across multiple lines. I guess mod_dav shouldbe updated to support 
that notation.

> ...

Best regards, Julian

-- 
<green/>bytes GmbH -- http://www.greenbytes.de -- tel:+492512807760

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org