You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/10/11 06:59:25 UTC
[PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
dongjoon-hyun opened a new pull request, #43328:
URL: https://github.com/apache/spark/pull/43328
### What changes were proposed in this pull request?
This PR aims to show the number of abnormaly completed drivers in MasterPage.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757070025
```
Drivers: 0 Running (0 Waiting), 7 Completed (1 Killed, 4 Failed, 0 Error)
```
This might be improved a bit, as it might cause ambiguity for users. After checking the DriverState enum, I noticed that Waiting(SUBMITTED) is separated from Running, but Killed, Failed, and Error states belong to Completed.
So the users might guess the Waiting ones are part of the Running ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1767538421
To @yaooqinn ,
> Also, RELAUNCHING might be considered as Waiting too
I tested the `RELAUNCHING` case by killing a worker and realized that I was confused. It's in `Completed Drivers` instead of `Running Drivers` because it's used by `removeDriver`.
https://github.com/apache/spark/blob/0cb4a84f6ab0c1bd101e6bc72be82987bbc02e9b/core/src/main/scala/org/apache/spark/deploy/master/Master.scala#L995
```
23/10/17 19:46:35 INFO Master: Telling app of lost executor: 0
23/10/17 19:46:35 INFO Master: Re-launching driver-20231017194619-0005
23/10/17 19:46:35 INFO Master: Removing driver: driver-20231017194619-0005
23/10/17 19:46:35 INFO Master: Start scheduling for app app-20231017194620-0005 with rpId: 0
23/10/17 19:46:35 WARN Master: App app-20231017194620-0005 requires more resource than any of Workers could have.
23/10/17 19:46:35 WARN Master: Driver driver-20231017194635-0006 requires more resource than any of Workers could have.
23/10/17 19:46:35 INFO Master: Start scheduling for app app-20231017194620-0005 with rpId: 0
23/10/17 19:46:35 WARN Master: App app-20231017194620-0005 requires more resource than any of Workers could have.
23/10/17 19:46:35 INFO Master: Telling app of lost worker: worker-20231017194525-127.0.0.1-56936
23/10/17 19:46:35 WARN Master: Driver driver-20231017194635-0006 requires more resource than any of Workers could have.
23/10/17 19:46:35 INFO Master: Start scheduling for app app-20231017194620-0005 with rpId: 0
23/10/17 19:46:35 WARN Master: App app-20231017194620-0005 requires more resource than any of Workers could have.
23/10/17 19:46:35 INFO Master: Received unregister request from application app-20231017194620-0005
```
I'll make a follow-up of this PR (SPARK-45500) instead of
- #43007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757075923
No, you are confused about this. Actually, `Running` including `Waiting`, @yaooqinn .
> Waiting(SUBMITTED) is separated from Running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1767546569
Here is the follow-up PR.
- https://github.com/apache/spark/pull/43418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43328: [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage
URL: https://github.com/apache/spark/pull/43328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757072880
Also, RELAUNCHING might be considered as Waiting too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1756981963
Could you review this PR when you have some time, @yaooqinn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757078509
The concept here is exposing the same content like Tables. For `RELAUNCHING`, I can add that for completeness as a follow-up for SPARK-45229.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757042860
Thank you so much, @yaooqinn !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757081130
For `Waiting` and `Running`, please see the screenshot of https://github.com/apache/spark/pull/43007 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1756995595
Could you review this PR, @LuciferYang , too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757166028
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757046690
Thank you, @LuciferYang , too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757088208
Thank you for clarifying @dongjoon-hyun. I will keep that in mind, and PR is ok to move forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1757096810
Thank you again for review, @yaooqinn ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45500][CORE][WEBUI] Show the number of abnormally completed drivers in MasterPage [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #43328:
URL: https://github.com/apache/spark/pull/43328#issuecomment-1767565971
Thank you, @dongjoon-hyun for the followup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org