You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2007/03/30 19:40:25 UTC

[jira] Created: (SOLR-201) bad exceptions when some options aren't in solrconfig.xml

bad exceptions when some options aren't in solrconfig.xml
---------------------------------------------------------

                 Key: SOLR-201
                 URL: https://issues.apache.org/jira/browse/SOLR-201
             Project: Solr
          Issue Type: Bug
            Reporter: Hoss Man


someone at work migrating from a pre-apache version of solr to the latest release ran into a nasty NegativeArraySizeException
today today because of these lines in DocSetHitCollector...

  static int HASHDOCSET_MAXSIZE= SolrConfig.config.getInt("//HashDocSet/@maxSize",-1);
  final int[] scratch = new int[HASHDOCSET_MAXSIZE];

(apparently in the version she was migrating from, not having that option set worked fine, i'm guessing it just never used HashDocSets)

we should fix that so it either has a sensible default, or at the very least throws a usefull error message .. it's probably worth auditing all of the config options as well.  

(i'm imagining a unit test using a solrconfig.xml file that is completely blank, and verifies that Solr starts up fine without exceptions, logs a bunch of warnings, and then sits there unable to do anything (since no request handlers are registered)



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-201) bad exceptions when some options aren't in solrconfig.xml

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-201.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

The HashDocSet maxSize is now 3000 by default instead of -1.

I've verified that Solr starts up fine without errors with a blank solrconfig.xml (just <config></config>). I'm not sure when this was fixed so I'm marking it as 1.4

> bad exceptions when some options aren't in solrconfig.xml
> ---------------------------------------------------------
>
>                 Key: SOLR-201
>                 URL: https://issues.apache.org/jira/browse/SOLR-201
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>             Fix For: 1.4
>
>
> someone at work migrating from a pre-apache version of solr to the latest release ran into a nasty NegativeArraySizeException
> today today because of these lines in DocSetHitCollector...
>   static int HASHDOCSET_MAXSIZE= SolrConfig.config.getInt("//HashDocSet/@maxSize",-1);
>   final int[] scratch = new int[HASHDOCSET_MAXSIZE];
> (apparently in the version she was migrating from, not having that option set worked fine, i'm guessing it just never used HashDocSets)
> we should fix that so it either has a sensible default, or at the very least throws a usefull error message .. it's probably worth auditing all of the config options as well.  
> (i'm imagining a unit test using a solrconfig.xml file that is completely blank, and verifies that Solr starts up fine without exceptions, logs a bunch of warnings, and then sits there unable to do anything (since no request handlers are registered)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.