You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ishark <gi...@git.apache.org> on 2015/10/15 02:45:09 UTC
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
GitHub user ishark opened a pull request:
https://github.com/apache/incubator-apex-core/pull/116
#SPOI-6505 #resolve Added check of @OutputPortFieldAnnotation with no…
… properties. One of the operators in Package had @OutputPortFieldAnnotation but did not have any properties in it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ishark/incubator-apex-core SPOI-6505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 9566a9b8216223d4e318ade6c17867793696b009
Author: ishark <is...@datatorrent.com>
Date: 2015-10-15T00:33:22Z
#SPOI-6505 #resolve Added check of @OutputPortFieldAnnotation with no properties. One of the operators in Package had @OutputPortFieldAnnotation but did not have any properties in it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by ishark <gi...@git.apache.org>.
Github user ishark commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/116#issuecomment-148873407
Thanks. Just squashed the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/116#issuecomment-148823228
Is this needed for v3.2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by ishark <gi...@git.apache.org>.
Github user ishark commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/116#issuecomment-148870778
Yes, one of the operators in Malhar has port annotation but no annotation properties. And that is part of demo packages. So, uploading of package fails without this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by ilganeli <gi...@git.apache.org>.
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/116#discussion_r42166013
--- Diff: engine/src/main/java/com/datatorrent/stram/webapp/asm/CompactUtil.java ---
@@ -153,12 +153,14 @@ private static void setAnnotationNode(FieldNode fn, CompactFieldNode cfn) {
if (annotation.desc.contains("InputPortFieldAnnotation")
|| annotation.desc.contains("OutputPortFieldAnnotation")) {
List<Object> annotationValues = annotation.values;
- int index = 0;
- while (index < annotationValues.size()) {
- annotationMap.put((String) annotationValues.get(index++), annotationValues.get(index++));
+ if (annotationValues != null) {
+ int index = 0;
+ while (index < annotationValues.size()) {
+ annotationMap.put((String) annotationValues.get(index++), annotationValues.get(index++));
--- End diff --
I would suggest extracting the two ```index++``` to ```String name = index++;``` and ```String val = index++;```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/116#issuecomment-148872576
OK, will cherry-pick it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: #SPOI-6505 #resolve Added check ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/116#issuecomment-148974031
In future, please use descriptive commit message with JIRA reference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---