You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:57:18 UTC
[GitHub] [airflow] collinmcnulty opened a new pull request #18414: Change the color for deferred status to mediumpurple
collinmcnulty opened a new pull request #18414:
URL: https://github.com/apache/airflow/pull/18414
Changes the color for the deferred status to something more distinct, blueviolet.
closes: #18245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925829029
I see now that I had generated a lot of extra files when I ran compile_assets.sh to test this. Now that I've rebased after #18461 and gone back to a clean clone, I've changed all remaining lightseagreen to blueviolet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925279337
Why don't you think we should? I'd argue we should be consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925840462
I'm not sure we should use such a "bold"/saturated colour here.
I realise that is subjective, but this makes it stand out an awful lot.
@andrewgodwin was your intent here to have a colour similar to `up_for_reschedule`, or did you pick a colour arbitrarily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18414: Change the color for deferred status to mediumpurple
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-936803897
Rebase should fix the failing tests:
```
tests/always/test_example_dags.py::TestExampleDags::test_should_be_importable: failed on setup with "Failed: Timeout >20.0s"
tests/always/test_example_dags.py::TestExampleDags::test_should_not_do_database_queries: failed on setup with "Failed: Timeout >20.0s"
tests/always/test_project_structure.py::TestProjectStructure::test_deprecated_packages: failed on setup with "Failed: Timeout >20.0s"
```
The timeout limitation was addressed in https://github.com/apache/airflow/pull/18505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed pull request #18414: Change the color for deferred status to mediumpurple
Posted by GitBox <gi...@apache.org>.
bbovenzi closed pull request #18414:
URL: https://github.com/apache/airflow/pull/18414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925874252
My goal was to pick a color that was a web safe "named" color that had sufficient color distance to skipped or up_for_reschedule. I recommend that we not use "similar" colors as they can be confusing. If we want them to be the same that's fine, but if they're different, they ought to be different enough to be obvious at a glance.
I'm open to other colors that meet these, I could try to find a less saturated purple that's still distinct enough from skipped's pink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on a change in pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on a change in pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#discussion_r715011641
##########
File path: airflow/utils/state.py
##########
@@ -112,17 +112,17 @@ class State:
TaskInstanceState.RUNNING: 'lime',
TaskInstanceState.SUCCESS: 'green',
TaskInstanceState.SHUTDOWN: 'blue',
- TaskInstanceState.RESTARTING: 'violet',
+ TaskInstanceState.RESTARTING: 'mediumpurple',
Review comment:
You are correct, find-and-replace error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925265421
@bbovenzi I did not see anywhere else that lightseagreen is except in CSS-like sections, which I don't think should be replaced. Can you provide an example of what you're referring to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrewgodwin commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
andrewgodwin commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925997853
I deliberately picked the same colour as the Smart Sensors `SENSING` state, as that was the most similar in concept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a change in pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#discussion_r715003660
##########
File path: airflow/utils/state.py
##########
@@ -112,17 +112,17 @@ class State:
TaskInstanceState.RUNNING: 'lime',
TaskInstanceState.SUCCESS: 'green',
TaskInstanceState.SHUTDOWN: 'blue',
- TaskInstanceState.RESTARTING: 'violet',
+ TaskInstanceState.RESTARTING: 'mediumpurple',
Review comment:
wait, I don't think restarting and deferred/sensing are supposed to be the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #18414: Change the color for deferred status to mediumpurple
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18414:
URL: https://github.com/apache/airflow/pull/18414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty edited a comment on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty edited a comment on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925887780
This is what is looks like if we use `violet` instead of `blueviolet`. Less bold, arguably not enough distance to pink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925827454
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed pull request #18414: Change the color for deferred status to mediumpurple
Posted by GitBox <gi...@apache.org>.
bbovenzi closed pull request #18414:
URL: https://github.com/apache/airflow/pull/18414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925887780
This is what is looks like if we use violet instead of blueviolet. Less bold, arguably not enough distance to pink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] collinmcnulty commented on pull request #18414: Change the color for deferred status to blueviolet
Posted by GitBox <gi...@apache.org>.
collinmcnulty commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-925891772
And here's `mediumpurple`. I think this might be the best choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org