You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2018/07/28 13:31:49 UTC
svn commit: r1836908 -
/ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
Author: adityasharma
Date: Sat Jul 28 13:31:49 2018
New Revision: 1836908
URL: http://svn.apache.org/viewvc?rev=1836908&view=rev
Log:
Improved: Add Option to update Facility Party Role on Edit Facility Party Role screen.
(OFBIZ-9085)
When using response type as 'view', the url of the page changes to specific request name. Instead of that it is better to use 'request-redirect' to give a better user experience. Hence, changing response type to 'request-redirect'.
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
Modified: ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml?rev=1836908&r1=1836907&r2=1836908&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml Sat Jul 28 13:31:49 2018
@@ -371,8 +371,12 @@ under the License.
<request-map uri="updateFacilityParty">
<security https="true" auth="true"/>
<event type="service" path="" invoke="updateFacilityParty"/>
- <response name="success" type="view" value="EditFacilityParties"/>
- <response name="error" type="view" value="EditFacilityParties"/>
+ <response name="success" type="request-redirect" value="EditFacilityParties">
+ <redirect-parameter name="facilityId"/>
+ </response>
+ <response name="error" type="request-redirect" value="EditFacilityParties">
+ <redirect-parameter name="facilityId"/>
+ </response>
</request-map>
<request-map uri="removePartyFromFacility">
<security https="true" auth="true"/>
Re: svn commit: r1836908 - /ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
Posted by Aditya Sharma <ad...@hotwaxsystems.com>.
Hi Deepak,
Yes, I missed that. I will update it ASAP.
Thanks for the heads up :)
Thanks and Regards,
*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
<http://www.hotwaxsystems.com/>
<https://www.linkedin.com/in/aditya-sharma-78291810a/>
On Mon, Jul 30, 2018 at 10:34 AM Deepak Dixit <de...@hotwax.co>
wrote:
> Hi Aditya,
>
> In case of error, we need to use view or request as response type as if we
> use request-redirect we need to redirect all the form parameter along with
> error messages.
>
>
> Thanks & Regards
> --
> Deepak Dixit
>
>
> On Sat, Jul 28, 2018 at 7:01 PM, <ad...@apache.org> wrote:
>
> > Author: adityasharma
> > Date: Sat Jul 28 13:31:49 2018
> > New Revision: 1836908
> >
> > URL: http://svn.apache.org/viewvc?rev=1836908&view=rev
> > Log:
> > Improved: Add Option to update Facility Party Role on Edit Facility Party
> > Role screen.
> > (OFBIZ-9085)
> > When using response type as 'view', the url of the page changes to
> > specific request name. Instead of that it is better to use
> > 'request-redirect' to give a better user experience. Hence, changing
> > response type to 'request-redirect'.
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> > facility/WEB-INF/controller.xml
> >
> > Modified: ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> > facility/WEB-INF/controller.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > applications/product/webapp/facility/WEB-INF/controller.
> > xml?rev=1836908&r1=1836907&r2=1836908&view=diff
> > ============================================================
> > ==================
> > --- ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> > facility/WEB-INF/controller.xml (original)
> > +++ ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> > facility/WEB-INF/controller.xml Sat Jul 28 13:31:49 2018
> > @@ -371,8 +371,12 @@ under the License.
> > <request-map uri="updateFacilityParty">
> > <security https="true" auth="true"/>
> > <event type="service" path="" invoke="updateFacilityParty"/>
> > - <response name="success" type="view"
> value="EditFacilityParties"/>
> > - <response name="error" type="view" value="EditFacilityParties"/>
> > + <response name="success" type="request-redirect"
> > value="EditFacilityParties">
> > + <redirect-parameter name="facilityId"/>
> > + </response>
> > + <response name="error" type="request-redirect"
> > value="EditFacilityParties">
> > + <redirect-parameter name="facilityId"/>
> > + </response>
> > </request-map>
> > <request-map uri="removePartyFromFacility">
> > <security https="true" auth="true"/>
> >
> >
> >
>
Re: svn commit: r1836908 - /ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
Posted by Deepak Dixit <de...@hotwax.co>.
Hi Aditya,
In case of error, we need to use view or request as response type as if we
use request-redirect we need to redirect all the form parameter along with
error messages.
Thanks & Regards
--
Deepak Dixit
On Sat, Jul 28, 2018 at 7:01 PM, <ad...@apache.org> wrote:
> Author: adityasharma
> Date: Sat Jul 28 13:31:49 2018
> New Revision: 1836908
>
> URL: http://svn.apache.org/viewvc?rev=1836908&view=rev
> Log:
> Improved: Add Option to update Facility Party Role on Edit Facility Party
> Role screen.
> (OFBIZ-9085)
> When using response type as 'view', the url of the page changes to
> specific request name. Instead of that it is better to use
> 'request-redirect' to give a better user experience. Hence, changing
> response type to 'request-redirect'.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> facility/WEB-INF/controller.xml
>
> Modified: ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> facility/WEB-INF/controller.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> applications/product/webapp/facility/WEB-INF/controller.
> xml?rev=1836908&r1=1836907&r2=1836908&view=diff
> ============================================================
> ==================
> --- ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> facility/WEB-INF/controller.xml (original)
> +++ ofbiz/ofbiz-framework/trunk/applications/product/webapp/
> facility/WEB-INF/controller.xml Sat Jul 28 13:31:49 2018
> @@ -371,8 +371,12 @@ under the License.
> <request-map uri="updateFacilityParty">
> <security https="true" auth="true"/>
> <event type="service" path="" invoke="updateFacilityParty"/>
> - <response name="success" type="view" value="EditFacilityParties"/>
> - <response name="error" type="view" value="EditFacilityParties"/>
> + <response name="success" type="request-redirect"
> value="EditFacilityParties">
> + <redirect-parameter name="facilityId"/>
> + </response>
> + <response name="error" type="request-redirect"
> value="EditFacilityParties">
> + <redirect-parameter name="facilityId"/>
> + </response>
> </request-map>
> <request-map uri="removePartyFromFacility">
> <security https="true" auth="true"/>
>
>
>