[GitHub] [kyuubi] hadoopkandy commented on a diff in pull request #5316: [KYUUBI #5315][FLINK] Propagate HIVE_CONF_DIR on launching Flink engine

["hadoopkandy (via GitHub)" <gi...@apache.org>]

hadoopkandy commented on code in PR #5316:
URL: https://github.com/apache/kyuubi/pull/5316#discussion_r1332668019


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -104,13 +104,23 @@ class FlinkProcessBuilder(
         val userJars = conf.get(ENGINE_FLINK_APPLICATION_JARS)
         userJars.foreach(jars => flinkExtraJars ++= jars.split(","))
 
+        val hiveConfDirOpt = env.get("HIVE_CONF_DIR")
+        hiveConfDirOpt.foreach { hiveConfDir =>
+          val hiveConf = s"${hiveConfDir}${File.separator}hive-site.xml"

Review Comment:
   i agree 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org